Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp2381962pxb; Mon, 19 Apr 2021 04:34:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyw+zE4tPFdGtC9mqIXqUbMlcUlxB8I9sLm28GjbzfI1U6EUaM0uDs4fsfLVhrFidi2Hme9 X-Received: by 2002:a17:906:cec2:: with SMTP id si2mr22230230ejb.234.1618832054192; Mon, 19 Apr 2021 04:34:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618832054; cv=none; d=google.com; s=arc-20160816; b=bVkM6xOSqHa2XEF88ADdOTV1N1/XQbqnx56LS6Mj+B17NvmVKJbqidIUlbHzQ6aOx7 CF6EPLwZA7scmX/mGPRZ4Q5UW00fkfofeddpffGIQs3ScvLj1Iuu/f/rESydHj2lshTH e/b7Q1toqZEO8JCy0EFXjV8qRSHHuUdgkLjW5y09JI5HYhDDMjCcZ7MQ5ZZEUdn9EBCQ ApotQMwMktd/lKnB/wIHOPMJSRhiKfuBiH3zamFvLxya9HEdxj6zO10UOo7Uahn6u4xu H5IjnzOJVs1EU0MZ3AzbNY6xtSx9DFJQ0dsxlEthjMAjY48nairkPP93JtSt5IbBXYOZ kBFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=nJsZMYoOlcWzMBGI0KcRtWMvYKThMhIFQHl+wj33bZk=; b=jsbb1MjoihoWSWMXNvoscywfRfeWQEtDhaYee2qyPWYvRJLNR/XR/YzFuWkF5Lhy3o IXwkDehWiqezeoE7Jy4WHqfdrhJbgNFOaVuNiDF0HYLTSPZOXH6pemtMRHkQrfFyRu3b g7qa8kItWif6tPD1XR7HZ2WAohEtRrE/xkqkgCb6csR62Bxe2hC4R331Bz16sk0osGuo kj8IqgTY55k1chM5RbyjuS0gKwF8lTYoR0BLRuM45T9/R56ruVx064QV5Z/iNkacodDL qjVGfrzBJ9GTb+8g0oYqAUqWfhcmo7ADx2cu2rKN8yTnUtIt0nhrWmIaV/1vbYh7uR4j qhiQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bm27si5258187edb.242.2021.04.19.04.33.49; Mon, 19 Apr 2021 04:34:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237734AbhDSLYZ (ORCPT + 99 others); Mon, 19 Apr 2021 07:24:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238058AbhDSLYV (ORCPT ); Mon, 19 Apr 2021 07:24:21 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9689C06174A for ; Mon, 19 Apr 2021 04:23:51 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1lYS0K-00DkQm-DB; Mon, 19 Apr 2021 13:23:48 +0200 Message-ID: Subject: Re: [PATCHv2] mac80211: fix NULL ptr dereference during mesh peer connection for non HE devices From: Johannes Berg To: Abinaya Kalaiselvan Cc: linux-wireless@vger.kernel.org Date: Mon, 19 Apr 2021 13:23:47 +0200 In-Reply-To: <1618483625-31097-1-git-send-email-akalaise@codeaurora.org> References: <1618483625-31097-1-git-send-email-akalaise@codeaurora.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Thu, 2021-04-15 at 16:17 +0530, Abinaya Kalaiselvan wrote: > "sband->iftype_data" is not assigned with any value for non HE supported > devices, which causes NULL pointer access during mesh peer connection > in those devices. Fix this by accessing the pointer after HE > capabilities condition check. > > Fixes: 7f7aa94bcaf0 (mac80211: reduce peer HE MCS/NSS to own capabilities) > Signed-off-by: Abinaya Kalaiselvan > --- > v2: > * ieee80211_sta_he_cap structure instance is initialized. > How about taking other feedback into account? johannes