Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp206727pxy; Tue, 20 Apr 2021 16:50:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyPzL5MsoxkpIEWLnCLY/MSZ46KwBFyMmrro4spK+g5L+uHW7TA4Z1t7ynr1hMj5xQXHGVi X-Received: by 2002:a50:8d8a:: with SMTP id r10mr34026418edh.132.1618962618302; Tue, 20 Apr 2021 16:50:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618962618; cv=none; d=google.com; s=arc-20160816; b=tGDK/OIUkYifXU1IZAiL46XjTGRvxupC8dL24Gh48BV1Q2O60nMUAvn5lSPJExJTuX 0nvPYGPG8iPUS3YMHawTyvHK3NX3ESxleeDN6SiVYiEJlQ4Be/7AwD25mk8jcYx7ELl6 CX2aJJnn2WwFh/5GQP5nr10bcwSwmbjwkPG6DyS8M8eLsCzCKX/jqmgYI9S+DATFYh17 sSMdq5HZly47vyORxfHBSTQJf1vw+qM1ce/MDmA+pHj8Vcyx33eQizgbDlJ+ghqxNNQ+ C22aYg9PwdE1rJ+fu9Fq3Lrd2Fpv7ipmNHiEbLQxIxe1OQRiQ+ue4NWWpPVx43I7vGSQ CE0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=gEN6JEqoWE/CpfWf3AwyHTFutwdaMWpMpmeq+w+PE/0=; b=yWWaFQfqQaf2CqNXDd1dlTbVjFmip2V4loV8x5CW2mgRcBrpSaH0ceTLr9KBshi55O EQ73IbRkyzfRsF725WluECQ4iFbCFLMFabRgtRSmf4DRG1Cr3dIM7gBQ6dxI6EVGT3wZ 44Edk4LxuWs402vdkoqZDtTKFw/4q8ouea0szDWdiLCcpwGJolmkAFhdm32+FZAx+rF5 T1Lu2FaTUm/FdRPCoQ4ZF2JaF5x2wL/zHokiLV0Q6HdbHItAFycHpXkGLtpoUdrk7dUx 7WuVu5gBl0uVFp1FTN7iiM3dbdzjciQ2ZlazqnpfLLTaR/4XbhmMwc+eI90bl5X5Y8Nv J93g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v13si182254ejg.212.2021.04.20.16.49.52; Tue, 20 Apr 2021 16:50:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234447AbhDTXsw (ORCPT + 99 others); Tue, 20 Apr 2021 19:48:52 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:34124 "EHLO mail.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234186AbhDTXsw (ORCPT ); Tue, 20 Apr 2021 19:48:52 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) by mail.monkeyblade.net (Postfix) with ESMTPSA id D874F4D2540BB; Tue, 20 Apr 2021 16:48:02 -0700 (PDT) Date: Tue, 20 Apr 2021 16:48:02 -0700 (PDT) Message-Id: <20210420.164802.229687091665923532.davem@davemloft.net> To: m.chetan.kumar@intel.com Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org, johannes@sipsolutions.net, krishna.c.sudi@intel.com, linuxwwan@intel.com Subject: Re: [PATCH V2 02/16] net: iosm: irq handling From: David Miller In-Reply-To: <20210420161310.16189-3-m.chetan.kumar@intel.com> References: <20210420161310.16189-1-m.chetan.kumar@intel.com> <20210420161310.16189-3-m.chetan.kumar@intel.com> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (mail.monkeyblade.net [0.0.0.0]); Tue, 20 Apr 2021 16:48:03 -0700 (PDT) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: M Chetan Kumar Date: Tue, 20 Apr 2021 21:42:56 +0530 > 1) Request interrupt vector, frees allocated resource. > 2) Registers IRQ handler. > > Signed-off-by: M Chetan Kumar > --- > v2: Streamline multiple returns using goto. > --- > drivers/net/wwan/iosm/iosm_ipc_irq.c | 91 ++++++++++++++++++++++++++++ > drivers/net/wwan/iosm/iosm_ipc_irq.h | 33 ++++++++++ > 2 files changed, 124 insertions(+) > create mode 100644 drivers/net/wwan/iosm/iosm_ipc_irq.c > create mode 100644 drivers/net/wwan/iosm/iosm_ipc_irq.h > > diff --git a/drivers/net/wwan/iosm/iosm_ipc_irq.c b/drivers/net/wwan/iosm/iosm_ipc_irq.c > new file mode 100644 > index 000000000000..a3e017604fa4 > --- /dev/null > +++ b/drivers/net/wwan/iosm/iosm_ipc_irq.c > @@ -0,0 +1,91 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (C) 2020-21 Intel Corporation. > + */ > + > +#include "iosm_ipc_pcie.h" > +#include "iosm_ipc_protocol.h" > + > +static inline void write_dbell_reg(struct iosm_pcie *ipc_pcie, int irq_n, > + u32 data) Please do not use inline in foo.c files, let the compiler decide. Thank you.