Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 21 Apr 2021 08:44:55 +0300
From:   Leon Romanovsky <leon@kernel.org>
To:     M Chetan Kumar <m.chetan.kumar@intel.com>
Cc:     netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
        johannes@sipsolutions.net, krishna.c.sudi@intel.com,
        linuxwwan@intel.com
Subject: Re: [PATCH V2 01/16] net: iosm: entry point
Message-ID: <YH+71wFykp/fWcCe@unreal>
References: <20210420161310.16189-1-m.chetan.kumar@intel.com>
 <20210420161310.16189-2-m.chetan.kumar@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210420161310.16189-2-m.chetan.kumar@intel.com>
Precedence: bulk

On Tue, Apr 20, 2021 at 09:42:55PM +0530, M Chetan Kumar wrote:
> 1) Register IOSM driver with kernel to manage Intel WWAN PCIe
>    device(PCI_VENDOR_ID_INTEL, INTEL_CP_DEVICE_7560_ID).
> 2) Exposes the EP PCIe device capability to Host PCIe core.
> 3) Initializes PCIe EP configuration and defines PCIe driver probe, remove
>    and power management OPS.
> 4) Allocate and map(dma) skb memory for data communication from device to
>    kernel and vice versa.
> 
> Signed-off-by: M Chetan Kumar <m.chetan.kumar@intel.com>
> ---
> v2:
> * Implement module_init() & exit() callbacks for rtnl_link.
> * Documentation correction for function signature.
> * Fix coverity warnings.
> ---
>  drivers/net/wwan/iosm/iosm_ipc_pcie.c | 588 ++++++++++++++++++++++++++
>  drivers/net/wwan/iosm/iosm_ipc_pcie.h | 211 +++++++++
>  2 files changed, 799 insertions(+)
>  create mode 100644 drivers/net/wwan/iosm/iosm_ipc_pcie.c
>  create mode 100644 drivers/net/wwan/iosm/iosm_ipc_pcie.h
> 
> diff --git a/drivers/net/wwan/iosm/iosm_ipc_pcie.c b/drivers/net/wwan/iosm/iosm_ipc_pcie.c
> new file mode 100644
> index 000000000000..8a3a8cd68a6a
> --- /dev/null
> +++ b/drivers/net/wwan/iosm/iosm_ipc_pcie.c
> @@ -0,0 +1,588 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (C) 2020-21 Intel Corporation.
> + */
> +
> +#include <linux/acpi.h>
> +#include <linux/bitfield.h>
> +#include <linux/module.h>
> +#include <net/rtnetlink.h>
> +
> +#include "iosm_ipc_imem.h"
> +#include "iosm_ipc_pcie.h"
> +#include "iosm_ipc_protocol.h"
> +
> +#define DRV_AUTHOR "Intel Corporation <linuxwwan@intel.com>"

Driver author can't be a company. It needs to be a person.

Thanks