Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@redhat.com>
To:     Kalle Valo <kvalo@codeaurora.org>
Cc:     linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath9k: Fix error check in ath9k_hw_read_revisions() for
 PCI devices
In-Reply-To: <87lf9cj969.fsf@codeaurora.org>
References: <20210326180819.142480-1-toke@redhat.com>
 <87a6puimgu.fsf@toke.dk> <87lf9cj969.fsf@codeaurora.org>
Date:   Wed, 21 Apr 2021 11:36:52 +0200
Message-ID: <87lf9cdlmz.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Kalle Valo <kvalo@codeaurora.org> writes:

> Toke H=C3=B8iland-J=C3=B8rgensen <toke@redhat.com> writes:
>
>>> When the error check in ath9k_hw_read_revisions() was added, it checked=
 for
>>> -EIO which is what ath9k_regread() in the ath9k_htc driver uses. Howeve=
r,
>>> for plain ath9k, the register read function uses ioread32(), which just
>>> returns -1 on error. So if such a read fails, it still gets passed thro=
ugh
>>> and ends up as a weird mac revision in the log output.
>>>
>>> Fix this by changing ath9k_regread() to return -1 on error like ioread3=
2()
>>> does, and fix the error check to look for that instead of -EIO.
>>>
>>> Fixes: 2f90c7e5d094 ("ath9k: Check for errors when reading SREV registe=
r")
>>> Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen <toke@redhat.com>
>>
>> Hi Kalle
>>
>> This patch is merged as "deferred" in patchwork - what's up with that?
>
> Just lack of time on my part. Reviewed-by tags would help a lot :)

Right, gotcha - will see if I can find someone to review :)

-Toke