Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp427597pxy; Wed, 21 Apr 2021 06:27:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx8bIs5eWryDxyMLS/AoWLgpKT9M8amh+RurcqVz6IqLcv37sn8T7mzqeS6u+Sr0e/AdDvK X-Received: by 2002:a62:808b:0:b029:252:eddc:afb0 with SMTP id j133-20020a62808b0000b0290252eddcafb0mr30856645pfd.41.1619011643285; Wed, 21 Apr 2021 06:27:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619011643; cv=none; d=google.com; s=arc-20160816; b=sAlTDTMeXz3dkDgFt/AygeF7aD7V/mw1X/AJnnWaKPYZdPO3jV5uhWNneebH/sxtmX 2L04xBd0tvSIabJ/OfRRrfqAdE5K3Arag0UTYkAN6zQVmb0hkguYe6dSNU7ofa7hAnS3 tkMtxzs29qSO3Q6TFnJ0aVBMMhKjiFWSTWSBMeiuakC/2dIOW9kHPSpcNxMDpGvQF1Ly P+I1YAuy0BLf01GnFlhTxe6Dtb7xvhHInZ/9Ry8Mz6LbBy1AnyGbK8UR4ame7CjuWk1K YOjxX0zMcZkJ8g4zxWXQjygcJ7gWDdOYXkjjqNu0qFf3NXtqFHQE3peHh7Xk91I3KEul LSLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :message-id:subject:cc:to:from:date:dkim-signature; bh=voSpbjx/x56pXz5sZw/CvfaDp0mSkH/RSK4TECgB8kk=; b=dV3hPoOEiqRuzuo/XDskio4c1+6GRPQvbw1OBjPT3a73dKp9YJRpVXgeCNxG+CUtF1 DokpDG7Ju5m8wzOGBpdulupuyeyCT0FJMksU3mYPdtN09xjHgqds79pBrezA5+JjwaFA 5Yjhx++nKhJ7GGtQWl18oaUWkDh2dejiRQtRLjkMRWPHIVhCNJxxOuZ08H0Q7n316oMk VapZss3kK/YKIlY3N4PnT8LQ23iCBem8H6jcjY/s+fKGaQ/KW+mbV24d+GYUiBRIpCeY wKkNoDqcZidkpSLizmapPs4eohf7IlyrtaSZW3dQ+Ofccrnn/Akjw+SYwchuSpwBAZDB bNng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=LzC4TYjn; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x13si2304804plx.253.2021.04.21.06.27.10; Wed, 21 Apr 2021 06:27:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=LzC4TYjn; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240753AbhDUN1Q (ORCPT + 99 others); Wed, 21 Apr 2021 09:27:16 -0400 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:15454 "EHLO mx0b-00069f02.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239158AbhDUN1P (ORCPT ); Wed, 21 Apr 2021 09:27:15 -0400 X-Greylist: delayed 684 seconds by postgrey-1.27 at vger.kernel.org; Wed, 21 Apr 2021 09:27:15 EDT Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 13LDDZDL017595; Wed, 21 Apr 2021 13:15:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=voSpbjx/x56pXz5sZw/CvfaDp0mSkH/RSK4TECgB8kk=; b=LzC4TYjngueQCSNQfKQi2Qd94J8kyx4A6a3haihNzDz5SJ0ZUyLL2UyrwruK1AIC4LO9 0BL2f7m8v050YsJz54oZ6U2rVGY52c+SHIWbgyuDQnmHyPt5ztA1ISWXeTj1EQjwK7++ 41pbviWy4SHIILXCtXji1DrbH82qT0xL1xizbN5G4hmG1fvRiTIyHeCxTYSt4Y/hZyCw 6v8FEJq4qsocRz2xHNLhKpr4EatrYd9cy/R+2ikDMOeFFUKIQyo/gy8eYymVtIKYyUjH i3z8sL2R1BBCSEZZRl63KIfAVGEvsYUnhTiHkGR7XuU2Gj9fF6xJlL4KP/4+JpZxQuIr MA== Received: from oracle.com (aserp3030.oracle.com [141.146.126.71]) by mx0b-00069f02.pphosted.com with ESMTP id 3819340qkw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 21 Apr 2021 13:15:26 +0000 Received: from aserp3030.oracle.com (aserp3030.oracle.com [127.0.0.1]) by pps.podrdrct (8.16.0.36/8.16.0.36) with SMTP id 13LDFMZi099267; Wed, 21 Apr 2021 13:15:25 GMT Received: from pps.reinject (localhost [127.0.0.1]) by aserp3030.oracle.com with ESMTP id 38098rqj3v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 21 Apr 2021 13:15:25 +0000 Received: from aserp3030.oracle.com (aserp3030.oracle.com [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 13LDFOZk099410; Wed, 21 Apr 2021 13:15:24 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3030.oracle.com with ESMTP id 38098rqj2w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 21 Apr 2021 13:15:24 +0000 Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 13LDFMOV023395; Wed, 21 Apr 2021 13:15:23 GMT Received: from mwanda (/102.36.221.92) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 21 Apr 2021 06:15:22 -0700 Date: Wed, 21 Apr 2021 16:15:14 +0300 From: Dan Carpenter To: Felix Fietkau Cc: Lorenzo Bianconi , Ryder Lee , Kalle Valo , Matthias Brugger , Shayne Chen , linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org, kernel-janitors@vger.kernel.org Subject: [PATCH 2/3] mt76: mt7915: fix a precision vs width bug in printk Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailer: git-send-email haha only kidding X-Proofpoint-ORIG-GUID: _DsSEl4YivLeT4BCMHLoEUKFyR-Hx3Ze X-Proofpoint-GUID: _DsSEl4YivLeT4BCMHLoEUKFyR-Hx3Ze Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Precision %.*s was intended instead of width %.*s. The original code will still print unintended data from beyond the end of skb->data. Fixes: 665b2c780d63 ("mt76: mt7915: limit firmware log message printk to buffer length") Signed-off-by: Dan Carpenter --- drivers/net/wireless/mediatek/mt76/mt7915/mcu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c index 908e74a6b8e6..94195a1ad3b8 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c +++ b/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c @@ -521,7 +521,7 @@ mt7915_mcu_rx_log_message(struct mt7915_dev *dev, struct sk_buff *skb) break; } - wiphy_info(mt76_hw(dev)->wiphy, "%s: %*s", type, + wiphy_info(mt76_hw(dev)->wiphy, "%s: %.*s", type, (int)(skb->len - sizeof(*rxd)), data); } -- 2.30.2