Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp428971pxy; Wed, 21 Apr 2021 06:29:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx7g6PyPMeD35xu8Rw9xkSrqQkJf+5D5iFZDD7RN1VmW9l6BN0legFzhpfg37fmUbhwppQc X-Received: by 2002:aa7:c1c9:: with SMTP id d9mr38239966edp.155.1619011756643; Wed, 21 Apr 2021 06:29:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619011756; cv=none; d=google.com; s=arc-20160816; b=ocjcgwScS2yF80Qdsuz3furUSYOx9I79I5O77zRptZCMt3Juri1mvqFqFA/rrAecxy 6etNN0YzuV2vEVw+mPAweRPfvsNZY2jkXUx6PfvB7Wj34llwijJT6JeZVrMsVoJc0+uw XoJvcRReTVfEVBYx21r+N8AvPFjhFHz3HwpbXblWcS1DvtWsNawU2gxJKSe5CMHa0gn7 ZoL3j6S8SoKB+xoFw7/vopq2A7YW2c9aKaXiWLdjwhv9Oa4KepnWMt8TVi/HDQWrP6PE 14gdA6kqmfSuMRqZ5RC/E5zm4M/LwreaH1u4sDhPDsqZg4byzaA2Ucgm7pfdtsE8U3A+ muKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature; bh=FlzphcOCSgX+2k3rUk5ygmbE2dHWikxsYFYPqUAoI5A=; b=G120zgy/eZmBlPQJXvJGSc1P2+7ax+408XfzOo71qsfesXrcr/tTzSKZEFYHCnK38H MLM0MfwXAgTOx50qg47569ghY3Qyrc06ZoOlFd9T7svDjAZHUjtoicCC9Gf6oJGmt5pC rrtCHLP4+9z9PmgSw0KsTQihS3cDIIyU8V0cDNcq716SXe2LXRDCXUvtI8PlkxHoFkf0 Bj7lua3hO+986+NRvml4j1RG1rqR4Bk2otwjtbo2C+8Gacvm9+TtM8ZJ+SNJ8WF0iSDM xy6LwR8PpwNSWeKFSrer6dNZiPdFvqe7UVwzGfEjsHqbbnipFYSiYXsRawxdf5ItytNk j+Qg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=vDAk9jhA; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ec10si1778877ejb.386.2021.04.21.06.28.52; Wed, 21 Apr 2021 06:29:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=vDAk9jhA; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241443AbhDUN1u (ORCPT + 99 others); Wed, 21 Apr 2021 09:27:50 -0400 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:54476 "EHLO mx0b-00069f02.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238455AbhDUN1t (ORCPT ); Wed, 21 Apr 2021 09:27:49 -0400 Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 13LDCEw9005847; Wed, 21 Apr 2021 13:15:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : mime-version : content-type; s=corp-2020-01-29; bh=FlzphcOCSgX+2k3rUk5ygmbE2dHWikxsYFYPqUAoI5A=; b=vDAk9jhA93QJm/tDNOkTo9apIGr5dShybhB+BrCKFXqBJL86F6Gl+N9stG+JyVEMDCOi sKmqXkx9QnkYcWXMLJ/5sBCOCoOU6FVdx8tKPOUuXDH1M/vnd/S4r3NmRIexi6SVpqwL XYbwAucWPfh66eyIPDbZz//gmFF6pJdVIoYWBiToKA4IleZ+tthQwPDOStg6pGgJ75Mg E2eA6tCy010xvN3MwyvfZ7nFXPtEtgL+Bd+SmKGD9mPx1wUdfkf6oejeBODEbYU/4tOB +hWTurCU2xa6xeDdRachcbvTmWhU5r+h5Ll03v8SlyCU/NSXaTjO9/dq68lqd5Pb83nK gw== Received: from oracle.com (aserp3030.oracle.com [141.146.126.71]) by mx0b-00069f02.pphosted.com with ESMTP id 381bjn8pra-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 21 Apr 2021 13:15:02 +0000 Received: from aserp3030.oracle.com (aserp3030.oracle.com [127.0.0.1]) by pps.podrdrct (8.16.0.36/8.16.0.36) with SMTP id 13LDF26f098309; Wed, 21 Apr 2021 13:15:02 GMT Received: from pps.reinject (localhost [127.0.0.1]) by aserp3030.oracle.com with ESMTP id 38098rqhhq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 21 Apr 2021 13:15:02 +0000 Received: from aserp3030.oracle.com (aserp3030.oracle.com [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 13LDF1uk098159; Wed, 21 Apr 2021 13:15:01 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 38098rqhdt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 21 Apr 2021 13:15:01 +0000 Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 13LDEqlP015391; Wed, 21 Apr 2021 13:14:52 GMT Received: from mwanda (/102.36.221.92) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 21 Apr 2021 06:14:52 -0700 Date: Wed, 21 Apr 2021 16:14:40 +0300 From: Dan Carpenter To: Felix Fietkau Cc: Lorenzo Bianconi , Ryder Lee , Kalle Valo , Matthias Brugger , Sean Wang , Soul Huang , linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org, kernel-janitors@vger.kernel.org Subject: [PATCH 1/3] mt76: mt7615: fix a precision vs width bug in printk Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding X-Proofpoint-GUID: IN-xhjViv_z8hvaYiIkNq2YIg1Cs348v X-Proofpoint-ORIG-GUID: IN-xhjViv_z8hvaYiIkNq2YIg1Cs348v Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Precision "%.*s" was intended instead of width "%*s". The original code will print garbage from beyond the end of the skb->data. Fixes: d76d6c3ba2b0 ("mt76: mt7615: limit firmware log message printk to buffer length") Signed-off-by: Dan Carpenter --- drivers/net/wireless/mediatek/mt76/mt7615/mcu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c index 9b9f8d88e9bb..00b1b657cb21 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c +++ b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c @@ -424,7 +424,7 @@ mt7615_mcu_rx_log_message(struct mt7615_dev *dev, struct sk_buff *skb) break; } - wiphy_info(mt76_hw(dev)->wiphy, "%s: %*s", type, + wiphy_info(mt76_hw(dev)->wiphy, "%s: %.*s", type, (int)(skb->len - sizeof(*rxd)), data); } -- 2.30.2