Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 2C943C43460
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] ath9k:remove unneeded variable in
 ath9k_dump_legacy_btcoex
From:   Kalle Valo <kvalo@codeaurora.org>
In-Reply-To: <20210224130356.51444-1-zhangkun4jr@163.com>
References: <20210224130356.51444-1-zhangkun4jr@163.com>
To:     zhangkun4jr@163.com
Cc:     "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, ath9k-devel@qca.qualcomm.com,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Zhang Kun <zhangkun@cdjrlc.com>
User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2
Message-Id: <20210421174610.B4FD1C433F1@smtp.codeaurora.org>
Date:   Wed, 21 Apr 2021 17:46:10 +0000 (UTC)
Precedence: bulk

zhangkun4jr@163.com wrote:

> From: Zhang Kun <zhangkun@cdjrlc.com>
> 
> Remove unneeded variable 'len' in ath9k_dump_legacy_btcoex.
> 
> Signed-off-by: Zhang Kun <zhangkun@cdjrlc.com>

This fails to compile. Always build check your patches!

In file included from drivers/net/wireless/ath/ath9k/gpio.c:17:
drivers/net/wireless/ath/ath9k/gpio.c: In function 'ath9k_dump_legacy_btcoex':
drivers/net/wireless/ath/ath9k/ath9k.h:763:3: error: 'len' undeclared (first use in this function)
  763 |   len += scnprintf(buf + len, size - len,  \
      |   ^~~
drivers/net/wireless/ath/ath9k/gpio.c:501:2: note: in expansion of macro 'ATH_DUMP_BTCOEX'
  501 |  ATH_DUMP_BTCOEX("Stomp Type", btcoex->bt_stomp_type);
      |  ^~~~~~~~~~~~~~~
drivers/net/wireless/ath/ath9k/ath9k.h:763:3: note: each undeclared identifier is reported only once for each function it appears in
  763 |   len += scnprintf(buf + len, size - len,  \
      |   ^~~
drivers/net/wireless/ath/ath9k/gpio.c:501:2: note: in expansion of macro 'ATH_DUMP_BTCOEX'
  501 |  ATH_DUMP_BTCOEX("Stomp Type", btcoex->bt_stomp_type);
      |  ^~~~~~~~~~~~~~~
make[5]: *** [drivers/net/wireless/ath/ath9k/gpio.o] Error 1
make[4]: *** [drivers/net/wireless/ath/ath9k] Error 2
make[3]: *** [drivers/net/wireless/ath] Error 2
make[2]: *** [drivers/net/wireless] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2

Patch set to Changes Requested.

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20210224130356.51444-1-zhangkun4jr@163.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches