Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org CD15DC433D3
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH -next v2] drivers: net: CONFIG_ATH9K select LEDS_CLASS and
 NEW_LEDS
From:   Kalle Valo <kvalo@codeaurora.org>
In-Reply-To: <20210330120533.102712-1-zhangjianhua18@huawei.com>
References: <20210330120533.102712-1-zhangjianhua18@huawei.com>
To:     Zhang Jianhua <zhangjianhua18@huawei.com>
Cc:     <ath9k-devel@qca.qualcomm.com>, <davem@davemloft.net>,
        <kuba@kernel.org>, <zhangjianhua18@huawei.com>,
        <linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <johnny.chenyi@huawei.com>
User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2
Message-Id: <20210422134251.30E07C4338A@smtp.codeaurora.org>
Date:   Thu, 22 Apr 2021 13:42:51 +0000 (UTC)
Precedence: bulk

Zhang Jianhua <zhangjianhua18@huawei.com> wrote:

> If CONFIG_ATH9K=y, the following errors will be seen while compiling
> gpio.c
> 
> drivers/net/wireless/ath/ath9k/gpio.o: In function `ath_deinit_leds':
> gpio.c:(.text+0x604): undefined reference to `led_classdev_unregister'
> gpio.c:(.text+0x604): relocation truncated to fit: R_AARCH64_CALL26
> against undefined symbol `led_classdev_unregister'
> drivers/net/wireless/ath/ath9k/gpio.o: In function `ath_init_leds':
> gpio.c:(.text+0x708): undefined reference to `led_classdev_register_ext'
> gpio.c:(.text+0x708): relocation truncated to fit: R_AARCH64_CALL26
> against undefined symbol `led_classdev_register_ext'
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhang Jianhua <zhangjianhua18@huawei.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Recently there was a related fix, I need more information about this problem.
What is exactly causing this? Is this a recent regression or an old problem?

Can someone review this?

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20210330120533.102712-1-zhangjianhua18@huawei.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches