Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp531470pxy; Thu, 22 Apr 2021 07:41:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwFoGUzcVXofnhGxDPhpd+RbcyQjJJViPHVj5WjP/SPsyiNyzhB3AF55Zg2rxcWs5E5eHzo X-Received: by 2002:a17:907:3e23:: with SMTP id hp35mr3762540ejc.437.1619102519225; Thu, 22 Apr 2021 07:41:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619102519; cv=none; d=google.com; s=arc-20160816; b=FpXYrnaw7amJSpZgdLED+Kg8cJTJe/HVp5uNrLWq0FLYP4HnZEh8bJfGtCRpnpQjSL NGGOjwB9c4hyJ3+IKkDyRy/eHzRGrK2Arm4V1Rw8Ao9bGei41m5a8lRuojN6u+pTNUjZ YKXvuqC22ePNBx9M1ow/vVkBP+RlFDdPezScaTe1SpmvidPZTH8hjfybLyVip+yzV4X8 8fbuNpUWrgpbROCHeNWdwuuyebkO1w5LFu19oAboHwzng9vxWq+CVc57BykOfAmIht9D Hf7cRtnxeQPZKKLGYCZJL/tQld2X87IU5mvYO7+ig8AhDEaIOSKC963aRG1K9CxOxsHN Lx8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dmarc-filter:sender:dkim-signature; bh=x1vvDozinm7jk7m1TjKGp29FQDnz/k2DrKuj47qUZe8=; b=UAeDUqfYLlgW3q+fLjMXJugwJj7i8MLszgIqwcfd9NRWXtOIUKa8azQqiebHmgvSXS TF0ZWboKP9FR8eL8MQ+u3wlu5Jh6nJnhcQ4TQ5hO0DS6uy6tmX8f/Uwrhvkqqd/GZJmC RzQZ94slbH0Ay43YkXQuA1szlr73nk9BqPdnGasFCCD0qnTG78jwFeq74lyI1ZjlsZ8g Y7RKsXJBQR/8+XbhmTdMCtcc+iT+4n/z5Fkm+98/WzDjKtKKtVDUKJ/fnaF3oiPKe7Zz YOyEPQS6hOuGgkMHgPe+Q0ABf6kXpb4KkiPlESHjczeCBQb4yyhbnFvNoZbYnDX7abZl whUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b="pG/jIMTv"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l9si2308076edc.528.2021.04.22.07.41.36; Thu, 22 Apr 2021 07:41:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b="pG/jIMTv"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236579AbhDVOlf (ORCPT + 99 others); Thu, 22 Apr 2021 10:41:35 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:17584 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237471AbhDVOld (ORCPT ); Thu, 22 Apr 2021 10:41:33 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1619102459; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=x1vvDozinm7jk7m1TjKGp29FQDnz/k2DrKuj47qUZe8=; b=pG/jIMTvWzt8h6zt3zc+txFLnigE/t4bYOt2jbCa9Bgyt+q5gE1gyuwTHeETGDju8rZSvKBz LqoLnLroqRst+rwUBNVN/sM3pkAgjdS5rJru8/KpxQaa6DrcjaT5+AQ/28/BBLpSYZz0opl6 eKcmdUFxNhAZ3Enimwj+7A4fZXs= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-west-2.postgun.com with SMTP id 60818af7febcffa80f71686a (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 22 Apr 2021 14:40:55 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 3613EC433D3; Thu, 22 Apr 2021 14:40:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,BAYES_00, MISSING_DATE,MISSING_MID,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id DE639C433F1; Thu, 22 Apr 2021 14:40:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org DE639C433F1 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2] qtnfmac: Fix possible buffer overflow in qtnf_event_handle_external_auth From: Kalle Valo In-Reply-To: <20210419145842.345787-1-leegib@gmail.com> References: <20210419145842.345787-1-leegib@gmail.com> To: Lee Gibson Cc: imitsyanko@quantenna.com, davem@davemloft.net, kuba@kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Lee Gibson User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20210422144055.3613EC433D3@smtp.codeaurora.org> Date: Thu, 22 Apr 2021 14:40:55 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Lee Gibson wrote: > Function qtnf_event_handle_external_auth calls memcpy without > checking the length. > A user could control that length and trigger a buffer overflow. > Fix by checking the length is within the maximum allowed size. > > Signed-off-by: Lee Gibson Patch applied to wireless-drivers-next.git, thanks. 130f634da1af qtnfmac: Fix possible buffer overflow in qtnf_event_handle_external_auth -- https://patchwork.kernel.org/project/linux-wireless/patch/20210419145842.345787-1-leegib@gmail.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches