Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <120f5db6566b583cc7050f13e947016f3cb82412.camel@sipsolutions.net>
Subject: Re: [PATCH v2][next] wireless: wext-spy: Fix out-of-bounds warning
From:   Johannes Berg <johannes@sipsolutions.net>
To:     "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>
Cc:     linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
        Kees Cook <keescook@chromium.org>
Date:   Thu, 22 Apr 2021 22:04:29 +0200
In-Reply-To: <20210422200032.GA168995@embeddedor>
References: <20210422200032.GA168995@embeddedor>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Thu, 2021-04-22 at 15:00 -0500, Gustavo A. R. Silva wrote:
> 
> Changes in v2:
>  - Use direct struct assignments instead of memcpy().
>  - Fix one more instance of this same issue in function
>    iw_handler_get_thrspy().
>  - Update changelog text.

Thanks.

>  - Add Kees' RB tag. 

He probably won't mind in this case, but you did some pretty substantial
changes to the patch, so I really wouldn't recommend keeping it there.

johannes