Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp1204274pxy; Fri, 23 Apr 2021 02:50:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzNdmW5sjn+395WIuiNUTPcrXOpFI4/k7FQlafSK465yOSLutDDI9HmRyDmHLiQUOPcAKFP X-Received: by 2002:a17:906:154f:: with SMTP id c15mr3298547ejd.142.1619171428879; Fri, 23 Apr 2021 02:50:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619171428; cv=none; d=google.com; s=arc-20160816; b=q7tSwcdPrqje1W5Bkfojf95/XCekdwvsVcL/KW5m1iIzccNPOnOu6UT5sTDdWksiWO g/94+2wsRSbGT/3leS7W/jnX5Aj7i/PLA2w7WKS5wAEOllHn2MyF6ixDfQSC5KweU5fQ wbNDD4oG3OXXUiblVbS6nqu4BQVK9dzb04CPrxz9MB2SuOtu2a/0Mtsel9vPpwkiulVl 3J6fdVeLcvpnvuZQLAAHONSMCpRBCzfnbcibc/aF8JrEuN5rkXNZ26VtL2W2QLPdJq07 XgIoZCmtouqWvUFVsbsgYPNWjBHVSgQ9KCirkbwiUC9d1fb8q3LX2RqH708ID0d/W+Nq qB+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=qGJknOp0Fjfs5Wkr2klPQ1xZyq4lzvCWiet6MP6DPGc=; b=A3oFf9sLj/t4xu3KaCJJCBEL6lx0IcDkar3NqHK3DBq4XgXnxDCgdQGkRpIm/sEzDl /DqahK+8vATJbMy08UxwXexiDRTXQa8P25YGL7SvWIp48/Fqvd87oeuZsOOuaYRhJnpP MaQhl/jVVLk1cOcSy7eXXzkmp1i+imKrJnq8mpfg66MSgSRV36PcS5qHLH3XT0ArrfJp H2sC8nHmmiAqn+HcwoqtN8hUhXxZgOvE2v/JY4Vji/8doUFt3NaPtnfgbsCXNlChX5GX NRTyjylV5AC1eHUx/1UXfuoNWjRnr03rEyfD21OQ++3CwRAqJQl4G0dZIqCa3lVbgh/h kRrQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=LO4gG5a0; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z19si5094806ejx.595.2021.04.23.02.50.04; Fri, 23 Apr 2021 02:50:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=LO4gG5a0; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241782AbhDWJug (ORCPT + 99 others); Fri, 23 Apr 2021 05:50:36 -0400 Received: from m12-14.163.com ([220.181.12.14]:40898 "EHLO m12-14.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229811AbhDWJug (ORCPT ); Fri, 23 Apr 2021 05:50:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=qGJkn Op0Fjfs5Wkr2klPQ1xZyq4lzvCWiet6MP6DPGc=; b=LO4gG5a0142Q5h8/GohYs yVQ0Nnc9AedKe4iRGJWgqVH+E25xnxzkwoiyqt6+1vM7kLOpAVSnmyaUl/K+M0D7 ovFWnY3n6DtQXx/LYK8iouxB46jDNKoSVIsi7LDITijVG1kSeGF6TKcWdeifz+EJ dfRDQbUKc4qVd/2lJA3YdY= Received: from COOL-20201210PM.ccdomain.com (unknown [218.94.48.178]) by smtp10 (Coremail) with SMTP id DsCowAA3km8rmIJgaCCyEw--.5294S2; Fri, 23 Apr 2021 17:49:35 +0800 (CST) From: zuoqilin1@163.com To: jussi.kivilinna@iki.fi, kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, zuoqilin Subject: [PATCH] wireless: Simplify expression Date: Fri, 23 Apr 2021 17:49:40 +0800 Message-Id: <20210423094940.1593-1-zuoqilin1@163.com> X-Mailer: git-send-email 2.28.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: DsCowAA3km8rmIJgaCCyEw--.5294S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7GF13XF4xGrW8Cr45tw4DCFg_yoWDJwc_Gr WIvF1kG34xXw1UKw48CFsxZryayr4DXFnYv3yjq3yakr45KFW8XrnYkFZxJr4DWw10yryx Cr12ka4xA3y0qjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU1hiStUUUUU== X-Originating-IP: [218.94.48.178] X-CM-SenderInfo: 52xr1xpolqiqqrwthudrp/xtbBRQd9iVPALUCsHwAAs7 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: zuoqilin It is not necessary to define the variable ret to receive the return value of the get_bssid() method. Signed-off-by: zuoqilin --- drivers/net/wireless/rndis_wlan.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/wireless/rndis_wlan.c b/drivers/net/wireless/rndis_wlan.c index 9fe7755..63ce244 100644 --- a/drivers/net/wireless/rndis_wlan.c +++ b/drivers/net/wireless/rndis_wlan.c @@ -1036,14 +1036,11 @@ static bool is_associated(struct usbnet *usbdev) { struct rndis_wlan_private *priv = get_rndis_wlan_priv(usbdev); u8 bssid[ETH_ALEN]; - int ret; if (!priv->radio_on) return false; - ret = get_bssid(usbdev, bssid); - - return (ret == 0 && !is_zero_ether_addr(bssid)); + return (get_bssid(usbdev, bssid) == 0 && !is_zero_ether_addr(bssid)); } static int disassociate(struct usbnet *usbdev, bool reset_ssid) -- 1.9.1