Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/1] staging: rtl8723bs: Move wiphy setup to after reading
 the regulatory settings from the chip
To:     youling257 <youling257@gmail.com>
Cc:     gregkh@linuxfoundation.org, johannes.berg@intel.com,
        linux-wireless@vger.kernel.org, ross.schm.dev@gmail.com
References: <20210201152956.370186-2-hdegoede@redhat.com>
 <20210426183406.13055-1-youling257@gmail.com>
From:   Hans de Goede <hdegoede@redhat.com>
Message-ID: <6dd2cb8b-5540-a410-92d8-f329be98327b@redhat.com>
Date:   Mon, 26 Apr 2021 20:43:10 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20210426183406.13055-1-youling257@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Youling,

On 4/26/21 8:34 PM, youling257 wrote:
> Hello, "cfg80211: Save the regulatory domain when setting custom
> regulatory" "cfg80211: Save the regulatory domain with a lock" cause
> rtl8723bs not work problem.
> I see upstream rtl8723bs driver "staging: rtl8723bs: Move wiphy setup
> to after reading the regulatory" "staging: rtl8723bs: fix wireless
> regulatory API misuse" fix problem.
> 
> I use rtl8723bs v5.2.17.1_26955.20180307_COEX20180201-6f52 driver, no
> the "rtw_wdev_alloc(padapter, dvobj_to_dev(dvobj));"
> 
> https://github.com/youling257/rockchip_wlan/blob/v5.2.17.1/rtl8723bs/os_dep/linux/ioctl_cfg80211.h#L234
> int rtw_wdev_alloc(_adapter *padapter, struct wiphy *wiphy);
> 
> https://github.com/torvalds/linux/blob/master/drivers/staging/rtl8723bs/include/ioctl_cfg80211.h#L91
> int rtw_wdev_alloc(struct adapter *padapter, struct device *dev);
> 
> https://github.com/torvalds/linux/blob/master/drivers/staging/rtl8723bs/os_dep/sdio_intf.c#L333
> https://github.com/youling257/rockchip_wlan/blob/v5.2.17.1/rtl8723bs/os_dep/linux/sdio_intf.c#L645
> 
> I want to fix rtl8723bs v5.2.17 not work problem, can you help me?

I'm not sure what your problem exactly is. If your kernel contains the

51d62f2f2c50 ("cfg80211: Save the regulatory domain with a lock")

Commit then you also need to backport (in the listed order):

81f153faacd0 ("staging: rtl8723bs: fix wireless regulatory API misuse")
50af06d43eab ("taging: rtl8723bs: Move wiphy setup to after reading the regulatory settings from the chip")

Which you seem to have already figured out ?

To keep the rtk8723bs driver working your kernel should either contain all 3 mentioned commits,
or it should contain none of them.

Regards,

Hans