Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp3900540pxy; Mon, 26 Apr 2021 12:30:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJycndsAyt/ZySNu6B2fpKDbX6DOk9SsPAIQTcmMsJAwhz7Cr9WA8NLYnLB8wtqFRZG1S/Jr X-Received: by 2002:a63:164a:: with SMTP id 10mr18954854pgw.186.1619465428352; Mon, 26 Apr 2021 12:30:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619465428; cv=none; d=google.com; s=arc-20160816; b=x4fFDHvGu/sTdGSgSAlteDXI0doMC0tFytFsBzioHm/HWLyJia+gEcBG6u5f8su/M0 KWF3NvFuqMEs0oWyoBMquP8/jFvjMWCvkPSgjDKJuSBN1vdrTk3O1sX1jlTPze30cic0 rR3+zasywWSURjeVTMyBuPHhG9t0u6ax8xKEeSe6bwm5rjN/dS4F37UFO7crObwmfqfw hCNYi0scYrbcW1oVbVZ4klhqS4orxK9RzLbH6qVby6GyUjxaZPwJHFPQUWx+3mtCnJc+ eMCK29ItlwVU8+AWjbf0CYvDfZjouh73sjyZS7rF9exVTUpyJFE9QxvPSQO2JKQF4Jka gKtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=d8xyoubKyTxzAVqhFDzvgqV0nQI51i7//feBrbOf67k=; b=UU0j686ufmrwS/0vYxDjagZAecxDtJZrwrishCWktnPTxkRJzhXp5tQp7D0d/XI0W7 UCoSww7BZcZK7m8CW9kDZGnIG7xCP7wqo5BNBnBcCkJjrfDVjGMA0/F1TTNklhMynbXB BENpSdvwgUiRhprHx2JbAl6eEJycqhzcEna377U+0iwe743VxPXFqVy0TPCAoHfoZbLj yjUv/OO3IA5Q2G+xFbG2/keD4nJm3VLdc9IlpPRigsC37dd2foc8E/L1dmQ4uGUjseOh FDrTezSWSjOKa6ycrCynQM4PbN1qyCWtWMW5t/OeEVDS6iyRbPK67LKO8qxvexxtW8ts kj/A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r21si822511pjp.98.2021.04.26.12.30.15; Mon, 26 Apr 2021 12:30:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240304AbhDZTaK (ORCPT + 99 others); Mon, 26 Apr 2021 15:30:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236653AbhDZTaK (ORCPT ); Mon, 26 Apr 2021 15:30:10 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E9ADC061574 for ; Mon, 26 Apr 2021 12:29:28 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1lb6v8-000MXK-Hv; Mon, 26 Apr 2021 21:29:26 +0200 From: Johannes Berg To: linux-wireless@vger.kernel.org Cc: Harald Arnesen , Johannes Berg Subject: [RFC PATCH] wil6210: remove erroneous wiphy locking Date: Mon, 26 Apr 2021 21:29:24 +0200 Message-Id: <20210426212922.83f1de07c2cd.I630a2a00eff185ba0452324b3d3f645e01128a95@changeid> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Johannes Berg We already hold the wiphy lock in all cases when we get here, so this would deadlock, remove the erroneous locking. Fixes: a05829a7222e ("cfg80211: avoid holding the RTNL when calling the driver") Signed-off-by: Johannes Berg --- drivers/net/wireless/ath/wil6210/cfg80211.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/wireless/ath/wil6210/cfg80211.c b/drivers/net/wireless/ath/wil6210/cfg80211.c index 6746fd206d2a..1ff2679963f0 100644 --- a/drivers/net/wireless/ath/wil6210/cfg80211.c +++ b/drivers/net/wireless/ath/wil6210/cfg80211.c @@ -2842,9 +2842,7 @@ void wil_p2p_wdev_free(struct wil6210_priv *wil) wil->radio_wdev = wil->main_ndev->ieee80211_ptr; mutex_unlock(&wil->vif_mutex); if (p2p_wdev) { - wiphy_lock(wil->wiphy); cfg80211_unregister_wdev(p2p_wdev); - wiphy_unlock(wil->wiphy); kfree(p2p_wdev); } } -- 2.30.2