Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210422182545.726897-1-manojgupta@google.com> <20210426163021.3594482-1-manojgupta@google.com>
In-Reply-To: <20210426163021.3594482-1-manojgupta@google.com>
From:   Brian Norris <briannorris@chromium.org>
Date:   Thu, 29 Apr 2021 10:59:56 -0700
Message-ID: <CA+ASDXNBXdriymXk3U=NtbDkg1rsTC7y6=VYMeJrY-y+9L-Asw@mail.gmail.com>
Subject: Re: [PATCH v2] iw: set retain atrribute on sections
To:     Manoj Gupta <manojgupta@google.com>
Cc:     Johannes Berg <johannes.berg@intel.com>,
        Johannes Berg <johannes@sipsolutions.net>,
        Luis Lozano <llozano@google.com>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        Fangrui Song <maskray@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

(removing stable@vger.kernel.org from CC)

On Mon, Apr 26, 2021 at 9:30 AM Manoj Gupta <manojgupta@google.com> wrote:
>
> LLD 13 and GNU ld 2.37 support -z start-stop-gc which allows garbage
> collection of C identifier name sections despite the __start_/__stop_
> references.  Simply set the retain attribute so that GCC 11 (if
> configure-time binutils is 2.36 or newer)/Clang 13 will set the
> SHF_GNU_RETAIN section attribute to prevent garbage collection.
>
> Without the patch, there are linker errors like the following with -z
> start-stop-gc:
> ld.lld: error: undefined symbol: __stop___cmd
> >>> referenced by iw.c:418
> >>>               iw.o:(__handle_cmd)
>
> Suggested-by: Fangrui Song <maskray@google.com>
>
> Cc: stable@vger.kernel.org
>
> Signed-off-by: Manoj Gupta <manojgupta@google.com>

This is not a kernel patch and so should not be sent to the
linux-stable list. I think Greg KH's bot already told you as much on
earlier versions.

See:
https://git.kernel.org/pub/scm/linux/kernel/git/jberg/iw.git/tree/README

"Please send all patches to Johannes Berg <johannes@sipsolutions.net>
and CC linux-wireless@vger.kernel.org for community review."

You're ~close.

Brian