Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp414667pxy; Fri, 30 Apr 2021 08:04:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJweqS7BCjGIERGDoEcIi9SlhIo0YHM3SdxfZV6x519Af1TiXXx0oGesvbwL3QLK0hEYn7Ru X-Received: by 2002:a17:906:2ac5:: with SMTP id m5mr4922569eje.517.1619795086854; Fri, 30 Apr 2021 08:04:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619795086; cv=none; d=google.com; s=arc-20160816; b=Ida3XH98RIlraP6uoNbWQ8CxDrJJKl15FVuJSW3yw4tM39A7S8ORikM6MY7zD02YZ8 2neI/OzMMDb/5daownWDGIteeN9c6XBDcPLuRfx1bcDbF7VHORRoEc55V6eQcncgx7Vk NORyTAx0fS3EdZSJNQkOkDOLTXBChrhtE4RAJ2NHFIQ8ozsEEc+c9PJ+QDtRKNQ5V1YN dtkNvHtkmBZ0jbzimq5h3MqxSE4/VMowmlOvvs4lVSNGahXhZy3u7vBYyMgd5eqIEFTU /ZuMluXiawmps0OMh30Ga1+y7vVFKLctTVehqv9vdnWbkBfERDF8p5dQS7XTklZKM1Ee uOTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=JR9UmrWoDiWpMuo03qcKfzGdq+H0q2FHL+CLZq8Opws=; b=vXi6RcMlAFMHW1LX+XSd6YFik3Ac7kxdcNLNheVod0CN1LKFJy2Hzwq6xRryf0QLAN hhRkt1Mj97DXRuoOukSrNzJuql+u6pA5eqqWvq5atJnP+erOnYdeLiEAdlo5g8SzUEQp NVP64u5+t09PSgM6Sxk4Q/S8yB3YaN2KvdXgKxD0+nShoCzh1TMGW8r7Udo3SY/xQkk+ ofY/X278Uas89cxbuzXIxgZKHqQ8rZyT8o6GGCZBnYXz9/1g5Wx3whTdm79EKYjkZk+J 3HcLDQxTX+A7rV/ZvyGbhCzxpoVlhIjZgwe4Nv78/AO3aQIF96r3Xf+8g8Cr+R8re40j mvWw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v13si2783230edl.448.2021.04.30.08.04.22; Fri, 30 Apr 2021 08:04:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233079AbhD3PBL (ORCPT + 99 others); Fri, 30 Apr 2021 11:01:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232070AbhD3PAo (ORCPT ); Fri, 30 Apr 2021 11:00:44 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADC60C06137B; Fri, 30 Apr 2021 07:59:10 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1lcUbe-00293F-0B; Fri, 30 Apr 2021 16:59:02 +0200 Message-ID: <573f85365f81b2505c90fd6e3e003faf48067abe.camel@sipsolutions.net> Subject: Re: [PATCH net] rsi: Add a NULL check in rsi_core_xmit From: Johannes Berg To: wangyunjian , kuba@kernel.org, davem@davemloft.net Cc: amitkarwar@gmail.com, siva8118@gmail.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, dingxiaoxiong@huawei.com Date: Fri, 30 Apr 2021 16:59:00 +0200 In-Reply-To: <1619794016-27348-1-git-send-email-wangyunjian@huawei.com> (sfid-20210430_164755_644415_C818D374) References: <1619794016-27348-1-git-send-email-wangyunjian@huawei.com> (sfid-20210430_164755_644415_C818D374) Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, 2021-04-30 at 22:46 +0800, wangyunjian wrote: > From: Yunjian Wang > > The skb may be NULL in rsi_core_xmit(). How so? Static checkers are good. Coverity is one of the better ones, in my experience. But blindly believing static checkers still isn't good. I see why the static checker is confused, but really, _you_ should have done that work, not me. johannes