Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp2898009pxy; Mon, 3 May 2021 10:25:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw4tU07NlG1FeNzFk/DHZ2e582oIVdHifb3d3fMuD9/wNx+FYjJ5A7inkKbe/FY9qZ/dmoM X-Received: by 2002:a05:6402:351:: with SMTP id r17mr21180004edw.186.1620062736345; Mon, 03 May 2021 10:25:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620062736; cv=none; d=google.com; s=arc-20160816; b=WqdMzFP9iLG+dgoeQaS/0qxU8Pfx8OnET7nX882DYXtqyuAR9TdGLzVrcdFEonuWQk GziMHqBCH5r+gY7dza+xZciU8yZlOrE+t+DPnMfY4cCdFAk70jGpIde4U4rZO+oVikU5 mKZi+jx4G5Oyi9aI775MdNR9+8ydoc+c8E+abPViNv7jUX17Gr+9X02IuSPowr2MW1dk qU5KCuBiYQI8ojpXBxwagWaINE6chdy2QjiI408bMkOROL4Snf0V1dg4FI1lMM6fmTJC nS3FGjTTj/opFi/7uHI7Sht/I//ZcoIjGpjuqEkROPEbAd5pGet8aeRsSNPFFYza+Sx/ z7NA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:message-id:references:in-reply-to :subject:cc:to:from:date:content-transfer-encoding:mime-version :sender:dkim-signature; bh=hsB8N+8JBY8AgfW7y30YN7AnS9xI7/dZQ0oNn0aKAKY=; b=r59TNNXGRf7o7ORg9YcUflZTMRKsQjjABMvhZDZ6Z0D/CwVQspN6GhntWL3hTzh4Ds HubuCSS2mDX/CtQg3wXRRbFmnFGjHIoJBO21xaZsM2nNEN52Crz7HcOAFRPbHT09Gi6u Kvck5KQOg21PF9qOY+C/cX10dmA/2rH3YqKqBpCs9bSKYZtUMykfdUHLDMzEVGy7wwgE 5SXF5klrg2poos2POwWFXQKxkEdHcdN5YllaaHHEbfjZCbJ/eiozFkIdamckz5JY2VW/ nNoKAnuqNNEmKB/FGF/pvOUA2QBVmexwcb01Og2V9E2E9n+RF2gmTGO+5aqXAcRLYE6p ATHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=F0OJSp5S; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id op18si299015ejb.39.2021.05.03.10.25.09; Mon, 03 May 2021 10:25:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=F0OJSp5S; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231393AbhECRZt (ORCPT + 99 others); Mon, 3 May 2021 13:25:49 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:60751 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231337AbhECRZt (ORCPT ); Mon, 3 May 2021 13:25:49 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1620062696; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=hsB8N+8JBY8AgfW7y30YN7AnS9xI7/dZQ0oNn0aKAKY=; b=F0OJSp5SOUmfqxFDTxJ3atfluuGfhuJ/NiIUz7fNjWVSNGLZ3Xl4gLC7a26aNQfGA2SOIWXA d6vx4tuwFr7bjtRUPmZrZZ9FoUvD06XzOHrmXcMjM7U+q+BEjJb3I/OqWXysAAKcCbyfaeIX lXVFL9fg6oaUC4QA97S5rY7uIAw= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-east-1.postgun.com with SMTP id 609031e82cbba889807a676e (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 03 May 2021 17:24:56 GMT Sender: jjohnson=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 5143AC43460; Mon, 3 May 2021 17:24:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: jjohnson) by smtp.codeaurora.org (Postfix) with ESMTPSA id 13C97C4338A; Mon, 3 May 2021 17:24:54 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 03 May 2021 10:24:54 -0700 From: jjohnson@codeaurora.org To: Maharaja Kennadyrajan Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, ath11k Subject: Re: [PATCH v2 1/3] nl80211: Add support for beacon tx mode In-Reply-To: <1619696874-30072-2-git-send-email-mkenna@codeaurora.org> References: <1619696874-30072-1-git-send-email-mkenna@codeaurora.org> <1619696874-30072-2-git-send-email-mkenna@codeaurora.org> Message-ID: <445ba573b519b9434d0e009eb9ff6f45@codeaurora.org> X-Sender: jjohnson@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2021-04-29 04:47, Maharaja Kennadyrajan wrote: [..snip..] > +/** > + * enum nl80211_beacon_tx_mode - Beacon Tx Mode enum. > + * Used to configure beacon staggered mode or beacon burst mode. > + */ > +enum nl80211_beacon_tx_mode { > + NL80211_BEACON_STAGGERED_MODE = 1, > + NL80211_BEACON_BURST_MODE = 2, > +}; > + [..snip..] > @@ -5330,6 +5331,10 @@ static int nl80211_start_ap(struct sk_buff *skb, > struct genl_info *info) > params.dtim_period = > nla_get_u32(info->attrs[NL80211_ATTR_DTIM_PERIOD]); > > + if (info->attrs[NL80211_ATTR_BEACON_TX_MODE]) > + params.beacon_tx_mode = > + > nla_get_u32(info->attrs[NL80211_ATTR_BEACON_TX_MODE]); > + Note that in the case where NL80211_ATTR_BEACON_TX_MODE is not specified that beacon_tx_mode will be zero, which is not a valid nl80211_beacon_tx_mode enumeration. Should you renumber the nl80211_beacon_tx_mode enumerations so that the default mode has a value of 0? Or add NL80211_BEACON_DEFAULT_MODE = 0 and allow the driver to select a default mode?