Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp3810103pxy; Tue, 4 May 2021 10:22:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwG+P3NHYZVNPQf8w3ksidNGy3xWGsYmK0rUmnhvhzn8uuKbO8jo+QBI/7FQYzYxAi1PQa0 X-Received: by 2002:a63:f608:: with SMTP id m8mr23609497pgh.54.1620148974739; Tue, 04 May 2021 10:22:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620148974; cv=none; d=google.com; s=arc-20160816; b=BozkjzrWPhU1qcQMOEJnjYbwCpPc5WXLz/PfpA8zjGaUUKUOA/RZ04nNOsfzMTBXnK dMcBCwBCrtxm8fIWmyvTxu0i02JR8CM89gYFy6TVnt9R8ZSBuvtEGhxEilKISPRaOsnf loratQgEpqjL5h+m0pJVHXoqW51sg7A8aqgoUWf5Yx16d4q42WQgFHqp0GQntFnc4CDO gOP3rezZnrCjULdXPeL1kjvWUdU/yrS1hHdCRrXdEKRiNIEN0fdxiLxkJqMQxGEmrBdC VsXFpkBueF/YHkhYPypne7+GdG7td+x9L3eZxpIa+jK6apj+avVu7PuSTyf/LB7Kc+Fv 9Fug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=XPnjEQdH/MrONQdDxv+LvDL8Izda1QOwVSGXaIaeUb8=; b=KiRTvTmNxeR1Sc1DrS6V2rACHnx0tSwwYOOnw0sRqXyiWBHVrLktDscTiqwTtDmAzN 6od7rY7Slshy0GdS10bKiyW7RScLNO/UKrA//ZmpSDg5pzl9b6OOhLuOKUZVtMD4uVd5 rWm75ydxVEmVvWZZXtrxKCy0m0KbsZXEU8ds9orNdxKiXD8yvS2obeOxGypqezvqqA+K RT2yJfgvKSvFoOMzDjZVhEKMNZabthZRRbWN0FaJwxRc6MgqRNr64i2Kh7JPbCrpTLkP 2ZYdJNLr7l6I4oT6w/8yiS+5RD2QX/HBp+xankK0ksLjv5BFoWHs16fBHsAPVpf+dVNN HKfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@quicinc.com header.s=qcdkim header.b=A2mLppbz; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 84si17477966pfu.307.2021.05.04.10.22.38; Tue, 04 May 2021 10:22:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@quicinc.com header.s=qcdkim header.b=A2mLppbz; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231168AbhEDRXZ (ORCPT + 99 others); Tue, 4 May 2021 13:23:25 -0400 Received: from alexa-out-sd-01.qualcomm.com ([199.106.114.38]:32672 "EHLO alexa-out-sd-01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230285AbhEDRXY (ORCPT ); Tue, 4 May 2021 13:23:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1620148950; x=1651684950; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=ssj0HmLsFhXdKgRKpNyTTL8WYgWUKhN0JFV+gJMwx80=; b=A2mLppbz75bcLILmVHWirLq2CaiKR0AzwDGKIA4F95aXgFgVSNbKgH4S HxjBdyuM5UKeYPdV8cWKUsazQh9fwJ0pnk7x4a09FG3HCMA6RQuqPiX9L Z2PYhORglP/N4ePD4cEi/rdl24ChErvWH27m6VGKEIuNfJuFD9DOpRvyl E=; Received: from unknown (HELO ironmsg03-sd.qualcomm.com) ([10.53.140.143]) by alexa-out-sd-01.qualcomm.com with ESMTP; 04 May 2021 10:22:29 -0700 X-QCInternal: smtphost Received: from nasanexm03e.na.qualcomm.com ([10.85.0.48]) by ironmsg03-sd.qualcomm.com with ESMTP/TLS/AES256-SHA; 04 May 2021 10:22:29 -0700 Received: from [10.226.59.216] (10.80.80.8) by nasanexm03e.na.qualcomm.com (10.85.0.48) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 4 May 2021 10:22:29 -0700 Subject: Re: [PATCH v1 1/6] bus: mhi: core: Set BHI/BHIe offsets on power up preparation To: Bhaumik Bhatt , CC: , , , , , , References: <1618598825-18629-1-git-send-email-bbhatt@codeaurora.org> <1618598825-18629-2-git-send-email-bbhatt@codeaurora.org> From: Jeffrey Hugo Message-ID: <5f0001da-bc1a-5649-ef72-1fbadd5b44ec@quicinc.com> Date: Tue, 4 May 2021 11:22:28 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <1618598825-18629-2-git-send-email-bbhatt@codeaurora.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanexm03h.na.qualcomm.com (10.85.0.50) To nasanexm03e.na.qualcomm.com (10.85.0.48) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 4/16/2021 12:47 PM, Bhaumik Bhatt wrote: > Set the BHI and/or BHIe offsets in mhi_prepare_for_power_up(), > rearrange the function, and remove the equivalent from > mhi_async_power_up(). This helps consolidate multiple checks > in different parts of the driver and can help MHI fail early on > before power up begins if the offsets are not read correctly. > > Signed-off-by: Bhaumik Bhatt > --- Reviewed-by: Jeffrey Hugo