Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210504212828.815-1-rsalvaterra@gmail.com> <20210505045044.GA735251@wp.pl>
In-Reply-To: <20210505045044.GA735251@wp.pl>
From:   Rui Salvaterra <rsalvaterra@gmail.com>
Date:   Wed, 5 May 2021 09:01:52 +0100
Message-ID: <CALjTZvYZ8Rr-UFyqFststt+vG+Ei1avUvPVxQwHe72QU0NEeKA@mail.gmail.com>
Subject: Re: [RFC PATCH] mt7601u: make the driver work again
To:     Stanislaw Gruszka <stf_xl@wp.pl>
Cc:     lorenzo@kernel.org, kuba@kernel.org, linux-wireless@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi, Stanislaw,

On Wed, 5 May 2021 at 05:50, Stanislaw Gruszka <stf_xl@wp.pl> wrote:
>
> I'm not sure if DPD calibration is needed. Maybe is ok to disable it for
> all MT7601U devices. However safer fix would be doing it only for
> devices that know to need it for work. For example: add dev->no_dpd_cal
> variable, set it based on USB ID (using usb_device_id->driver_info) and
> do not perfrom calibration when it's set.

Hm=E2=80=A6 the struct usb_device already contains a u32 quirks. Shouldn't =
it
be used instead, or is it used for an entirely different set of
quirks?

> Also please clarify "work again" in the topic. Have your device ever
> worked with mt7601u driver in some older kernel version?

Personally, my devices never worked. I ordered a bunch of them
dirt-cheap from AliExpress, in early 2019. I needed one for my RPi,
running OpenWrt 19.07 (Linux 4.19), but it failed the same way. I
thought it might be a problem with the driver on ARM, I replaced it
with a Ralink adapter and it worked fine. I hadn't used the devices
until a couple of days ago, when I needed to connect a x86 machine and
saw the exact same error I had seen on the Pi.

Thanks
Rui