Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] ARM: dts: am5729-beagleboneai: drop unused Broadcom WiFi
 properties
To:     Robert Nelson <robertcnelson@gmail.com>,
        alexey.roslyakov@gmail.com, Drew Fustini <drew@beagleboard.org>,
        Jason Kridner <jkridner@beagleboard.org>
Cc:     =?UTF-8?Q?Beno=c3=aet_Cousson?= <bcousson@baylibre.com>,
        Tony Lindgren <tony@atomide.com>,
        Rob Herring <robh+dt@kernel.org>,
        linux-omap <linux-omap@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        linux kernel <linux-kernel@vger.kernel.org>,
        linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com
References: <20210505140015.60013-1-krzysztof.kozlowski@canonical.com>
 <CAOCHtYiicw5bqaZU5g2QGJHG3DZKRQUwAr08NZHw81S9=hmrgw@mail.gmail.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Message-ID: <7ced6d2f-7107-e612-6787-63e38e5e3edd@canonical.com>
Date:   Wed, 5 May 2021 10:22:37 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <CAOCHtYiicw5bqaZU5g2QGJHG3DZKRQUwAr08NZHw81S9=hmrgw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 05/05/2021 10:15, Robert Nelson wrote:
> On Wed, May 5, 2021 at 9:04 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@canonical.com> wrote:
>>
>> The brcm,sd-head-align, brcm,sd_head_align and brcm,sd_sgentry_align are
>> not used by the driver and not present in dtschema:
>>
>>   arch/arm/boot/dts/am5729-beagleboneai.dt.yaml: wifi@1:
>>     'brcm,sd-head-align', 'brcm,sd_head_align', 'brcm,sd_sgentry_align' do not match any of the regexes: 'pinctrl-[0-9]+'
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>> ---
>>  arch/arm/boot/dts/am5729-beagleboneai.dts | 4 ----
>>  1 file changed, 4 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/am5729-beagleboneai.dts b/arch/arm/boot/dts/am5729-beagleboneai.dts
>> index 149cfafb90bf..d3b2e87a6266 100644
>> --- a/arch/arm/boot/dts/am5729-beagleboneai.dts
>> +++ b/arch/arm/boot/dts/am5729-beagleboneai.dts
>> @@ -582,10 +582,6 @@ brcmf: wifi@1 {
>>                 reg = <1>;
>>                 compatible = "brcm,bcm4329-fmac";
>>
>> -               brcm,sd-head-align = <4>;
>> -               brcm,sd_head_align = <4>;
>> -               brcm,sd_sgentry_align = <512>;
>> -
>>                 interrupt-parent = <&gpio3>;
>>                 interrupts = <23 IRQ_TYPE_LEVEL_LOW>;
>>                 interrupt-names = "host-wake";
>> --
>> 2.25.1
>>
> 
> NAK, for what it is worth..
> 
> This is a plain old shitty situation, that everyone that mistakenly
> chooses a BRCM based chipset in a design faces, then learns to NEVER
> touch that chipset again..
> 
> These nodes have been posted before for mainline inclusion but always
> get killed off:
> 
> https://lkml.org/lkml/2018/3/18/356
> 
> The TI AM57xx SDIO needs these flags for the brcmfmac driver to actually work.
> 
> I don't see the brcmfmac developers actually fixing it, as "out of
> tree" work for brcmfmac is 100+ patches long:


Thanks for explanation. I understand these are actually used by
out-of-tree driver? That's a valid reason to add them to the binding then...

> 
> https://www.cypress.com/documentation/software-and-drivers-archive/wifi-bt-linux-archive?source=search&cat=other

Requires login - I am not able to get the sources.

Best regards,
Krzysztof