Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <24356aa7737d5d0bbf9481bbba89b4248811ebce.camel@gapps.redhat.com>
Subject: Re: [PATCH V2 07/16] net: iosm: mbim control device
From:   Dan Williams <dcbw@gapps.redhat.com>
To:     "Kumar, M Chetan" <m.chetan.kumar@intel.com>,
        Loic Poulain <loic.poulain@linaro.org>
Cc:     Network Development <netdev@vger.kernel.org>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "johannes@sipsolutions.net" <johannes@sipsolutions.net>,
        "Sudi, Krishna C" <krishna.c.sudi@intel.com>,
        linuxwwan <linuxwwan@intel.com>
Date:   Thu, 06 May 2021 09:09:18 -0500
In-Reply-To: <fd6b57f1e3b1444383ad5387de36e1cc@intel.com>
References: <20210420161310.16189-1-m.chetan.kumar@intel.com>
         <20210420161310.16189-8-m.chetan.kumar@intel.com>
         <CAMZdPi8h7ubOvUBaF2wh87UBwzJz3GpQ3gZwSXy0miV7Aw2NXw@mail.gmail.com>
         <fd6b57f1e3b1444383ad5387de36e1cc@intel.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 2021-05-06 at 10:44 +0000, Kumar, M Chetan wrote:
> Hi Loic,
> 
> > > 
> > > Implements a char device for MBIM protocol communication &
> > > provides a
> > > simple IOCTL for max transfer buffer size configuration.
> > > 
> > > Signed-off-by: M Chetan Kumar <m.chetan.kumar@intel.com>
> > 
> > Now that the initial wwan framework support landed, could you
> > migrate to it
> > for creating the MBIM 'WWAN port' instead of creating yet another
> > char
> > driver? I see you introduced an IOCTL for packet size, I see no
> > objection to
> > add that in the wwan core.
> > 
> 
> Sure, we have started the migration to MBIM 'WWAN port'. The next
> version of patch
> would contain these adaptations.
> 
> If wwan core supports IOCTL for packet size, then we shall remove
> that piece of
> implementation in driver code.

There has got to be a better way to do that than an ioctl. ioctls are
not looked on favorably these days. Usually it's sysfs files or netlink
config instead.

Dan