Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp545560pxj; Fri, 7 May 2021 14:33:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxklUSQKHs62D6IvvGlh+o75qu47+aAHdMYzKN4azyTeUwxtcgTVN2h7SyKy8bI+gkKyi0x X-Received: by 2002:a17:90a:1d44:: with SMTP id u4mr26478704pju.46.1620423214182; Fri, 07 May 2021 14:33:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620423214; cv=none; d=google.com; s=arc-20160816; b=YUbZap52ZWJtzA1l45+jrJiwQGkaEstGXjhKQB6mYmAzhsp0Kmymccl4Z7E9rs2vZq bFak4ea0vH9mqa/ce6ZYq3rzY4BFs4rpNO9XHotpXkie1yjYqRSfl3BcjiU1bljlqgj1 chP5jwbNuPYG9JV4RRrjp100g94Ksulx858Q9fH2FSiIixck1I/i/1kp5iLZ/gUI5Khe WrbaMNWpwBGnrBD/IsFLaFJapMtMVEExZI/s0KTN3dBQxXp4Hg7ibPZ3P+2KuTxi9P+P I69WsbYJwIBX5DaGzhxXSg70ON9xSRlsm4xaoYEu8zcZUIeTG3fu2iwjjyD0FZDmAHRU w7mQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=o4/gHmXu58eNBuIOxxGt66kzOFcAYTx++O+I5qwK17s=; b=VEqe2ywNSZGl5Ap6x8QAJHPqMDTnEB8ZACWDylI1/usIdix4gOfBgZ1ehbKhloUAq8 21yMwWUWvdkGtFPuWhsS6aEKJ2BwkKsVDVeawJxgBI8tJQ25K/4obi0OLKWBqZWcdSSA rw5LnTtpHr7hzw7V0eP8Xn3Ztp6n7C7lPOWCkdGcCs3AG0SboO11PYTf4Q664AYUCeNm 99Ro4wr1YhNmGZSRdWqsQ4PYmGD2bCsKMiltm5A5iuakoTLucQH0ubmtxPpDOMnjq+d3 P50Mzw3cvpIJ2qf4LD0uUU14mHyBZDqGntgm8GlqljP4+/0hSx73aJA3kkgiEbnzB3Xg H00Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@denx.de header.s=phobos-20191101 header.b=iBdNCaAC; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r16si2061520pgv.383.2021.05.07.14.33.21; Fri, 07 May 2021 14:33:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@denx.de header.s=phobos-20191101 header.b=iBdNCaAC; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229760AbhEGVcc (ORCPT + 99 others); Fri, 7 May 2021 17:32:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229696AbhEGVcb (ORCPT ); Fri, 7 May 2021 17:32:31 -0400 Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C82DC0613ED; Fri, 7 May 2021 14:31:31 -0700 (PDT) Received: from tr.lan (ip-89-176-112-137.net.upcbroadband.cz [89.176.112.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id F2F4182E47; Fri, 7 May 2021 23:31:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1620423084; bh=o4/gHmXu58eNBuIOxxGt66kzOFcAYTx++O+I5qwK17s=; h=From:To:Cc:Subject:Date:From; b=iBdNCaACtLdoOnLiCyqHIfxkaEt/A7E34W/t8RtkKklLoqicVA7kkIYOwx+4V7jAm hQu4btPU5xzzmQ4ZrW2lU7LheYFJpNNnC6f0UvurLPD2ZV5dzU00NZx3hvs/uvFcO/ shEsE9TFV+AVnR735rCI/YoCS/85rIYvLzWHLaoJAzF2sJU5+q5XCqKGDopn/p6/BZ IdAO3Fya+4kJPR8Gmo98byWBtiP+MlD4/izqWXRPYViGcJ8uIR//JRBr55YSbNxlJc 7/zaoTPg/KuPhfCvDUFgdN8kcJ3GRuKAryfnrFQueIMTnqLIloIDEpXSF/1sCdkGGd +ozUBr5BnwzIg== From: Marek Vasut To: linux-wireless@vger.kernel.org Cc: Marek Vasut , Amitkumar Karwar , Angus Ainslie , "David S . Miller" , Jakub Kicinski , Kalle Valo , Karun Eagalapati , Martin Kepplinger , Prameela Rani Garnepudi , Sebastian Krzyszkowiak , Siva Rebbagondla , netdev@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH] rsi: Assign beacon rate settings to the correct rate_info descriptor field Date: Fri, 7 May 2021 23:31:05 +0200 Message-Id: <20210507213105.140138-1-marex@denx.de> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org The RSI_RATE_x bits must be assigned to struct rsi_data_desc rate_info field. The rest of the driver does it correctly, except this one place, so fix it. This is also aligned with the RSI downstream vendor driver. Without this patch, an AP operating at 5 GHz does not transmit any beacons at all, this patch fixes that. Fixes: d26a9559403c ("rsi: add beacon changes for AP mode") Signed-off-by: Marek Vasut Cc: Amitkumar Karwar Cc: Angus Ainslie Cc: David S. Miller Cc: Jakub Kicinski Cc: Kalle Valo Cc: Karun Eagalapati Cc: Martin Kepplinger Cc: Prameela Rani Garnepudi Cc: Sebastian Krzyszkowiak Cc: Siva Rebbagondla Cc: netdev@vger.kernel.org Cc: stable@vger.kernel.org --- drivers/net/wireless/rsi/rsi_91x_hal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/rsi/rsi_91x_hal.c b/drivers/net/wireless/rsi/rsi_91x_hal.c index ce9892152f4d..ab837921d9a4 100644 --- a/drivers/net/wireless/rsi/rsi_91x_hal.c +++ b/drivers/net/wireless/rsi/rsi_91x_hal.c @@ -470,9 +470,9 @@ int rsi_prepare_beacon(struct rsi_common *common, struct sk_buff *skb) } if (common->band == NL80211_BAND_2GHZ) - bcn_frm->bbp_info |= cpu_to_le16(RSI_RATE_1); + bcn_frm->rate_info |= cpu_to_le16(RSI_RATE_1); else - bcn_frm->bbp_info |= cpu_to_le16(RSI_RATE_6); + bcn_frm->rate_info |= cpu_to_le16(RSI_RATE_6); if (mac_bcn->data[tim_offset + 2] == 0) bcn_frm->frame_info |= cpu_to_le16(RSI_DATA_DESC_DTIM_BEACON); -- 2.30.2