Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 8 May 2021 14:02:35 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     Johannes Berg <johannes@sipsolutions.net>,
        Arend van Spriel <aspriel@gmail.com>,
        Matthias Brugger <mbrugger@suse.com>,
        Franky Lin <franky.lin@broadcom.com>,
        Hante Meuleman <hante.meuleman@broadcom.com>,
        Chi-hsien Lin <chi-hsien.lin@infineon.com>,
        Wright Feng <wright.feng@infineon.com>,
        Chung-hsien Hsu <chung-hsien.hsu@infineon.com>,
        Kalle Valo <kvalo@codeaurora.org>,
        Hans deGoede <hdegoede@redhat.com>,
        linux-wireless@vger.kernel.org,
        brcm80211-dev-list.pdl@broadcom.com,
        kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] brcmfmac: fix a loop exit condition
Message-ID: <20210508110235.GM1922@kadam>
References: <YIKzmoMiTdToaIyP@mwanda>
 <427e33af49758c61bc23cf1eedb6dd6964c40296.camel@sipsolutions.net>
 <20210423121110.GO1981@kadam>
 <bda7ae6b-00f9-ae0e-66d3-413049bc543d@wanadoo.fr>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <bda7ae6b-00f9-ae0e-66d3-413049bc543d@wanadoo.fr>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Fri, Apr 23, 2021 at 02:20:35PM +0200, Christophe JAILLET wrote:
> Le 23/04/2021 ? 14:11, Dan Carpenter a ?crit?:
> > On Fri, Apr 23, 2021 at 01:59:36PM +0200, Johannes Berg wrote:
> > > On Fri, 2021-04-23 at 14:46 +0300, Dan Carpenter wrote:
> > > > This code is supposed to loop over the whole board_type[] string.  The
> > > > current code kind of works just because ascii values start 97 and the
> > > > string is likely shorter than that so it will break when we hit the NUL
> > > > terminator.  But really the condition should be "i < len" instead of
> > > > "i < board_type[i]".
> > > > 
> > > > Fixes: 29e354ebeeec ("brcmfmac: Transform compatible string for FW loading")
> > > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > > > ---
> > > >  ?drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c | 2 +-
> > > >  ?1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
> > > > index a7554265f95f..9b75e396fc50 100644
> > > > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
> > > > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
> > > > @@ -34,7 +34,7 @@ void brcmf_of_probe(struct device *dev, enum brcmf_bus_type bus_type,
> > > >  ?		len = strlen(tmp) + 1;
> > > >  ?		board_type = devm_kzalloc(dev, len, GFP_KERNEL);
> > > >  ?		strscpy(board_type, tmp, len);
> > > > -		for (i = 0; i < board_type[i]; i++) {
> > > > +		for (i = 0; i < len; i++) {
> > > >  ?			if (board_type[i] == '/')
> > > >  ?				board_type[i] = '-';
> > > >  ?		}
> > > 
> > > It should probably just use strreplace() though :)
> > 
> > Good point.  I'll send a v2.
> > 
> 
> and the 2 lines above look like a devm_kstrdup.
> 
> The (unlikely) malloc failure test is also missing.

It turns out that Smatch checks for allocation failure were really
ancient and really crap...  I need to add all devm_ functions.
Probably should re-write all that code.

Also originally GFP_NOFAIL was 0x800 and now it is 0x8000.  Smatch
was out of sync.  So the functions that were supposed to be checked
were all disabled...  Need to figure out a better way to do that as
well.

regards,
dan carpenter