Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/1] b43: phy_n: Delete some useless empty code
From:   "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     Kalle Valo <kvalo@codeaurora.org>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        b43-dev <b43-dev@lists.infradead.org>,
        netdev <netdev@vger.kernel.org>
References: <20210510145117.4066-1-thunder.leizhen@huawei.com>
 <YJmRUQwPPDE+hWiN@lunn.ch> <1890aa92-ddf2-78f7-51e7-bdc3a58a04c6@huawei.com>
Message-ID: <c7c7c332-acc3-4907-1c7d-ccf2413ef837@huawei.com>
Date:   Tue, 11 May 2021 11:00:07 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.0
MIME-Version: 1.0
In-Reply-To: <1890aa92-ddf2-78f7-51e7-bdc3a58a04c6@huawei.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2021/5/11 9:11, Leizhen (ThunderTown) wrote:
> 
> 
> On 2021/5/11 4:02, Andrew Lunn wrote:
>> On Mon, May 10, 2021 at 10:51:17PM +0800, Zhen Lei wrote:
>>> These TODO empty code are added by
>>> commit 9442e5b58edb ("b43: N-PHY: partly implement SPUR workaround"). It's
>>> been more than a decade now. I don't think anyone who wants to perfect
>>> this workaround can follow this TODO tip exactly. Instead, it limits them
>>> to new thinking. Remove it will be better.
>>>
>>> No functional change.
>>
>> No function change, apart from the new warning?
>>
>> Does your bot to compile the change and look for new warnings/errors?
> 
> Sorry, I have compiled it. I guess it's probably separated by macros, which I didn't notice. I will check it.

I got it. It reported by W=1.

> 
>>
>>      Andrew
>>
>> .
>>