Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org AC824C433D3
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Brian Norris <briannorris@chromium.org>
Cc:     Pkshih <pkshih@realtek.com>,
        "linux-firmware\@kernel.org" <linux-firmware@kernel.org>,
        "linux-wireless\@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: Request to update 8852a firmware of rtw89 to v0.13.8.0
References: <57e9f582340545c79a9ab3433e2a4a7d@realtek.com>
        <87cztx87tr.fsf@tynnyri.adurom.net>
        <CA+ASDXM9YmhMWmttkrCxB0_tf6Kf6Sz=7Yc26CmjZmMUxyxAfw@mail.gmail.com>
Date:   Thu, 13 May 2021 09:09:00 +0300
In-Reply-To: <CA+ASDXM9YmhMWmttkrCxB0_tf6Kf6Sz=7Yc26CmjZmMUxyxAfw@mail.gmail.com>
        (Brian Norris's message of "Tue, 11 May 2021 12:10:55 -0700")
Message-ID: <87tun7i2rn.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Brian Norris <briannorris@chromium.org> writes:

> On Tue, May 11, 2021 at 11:05 AM Kalle Valo <kvalo@codeaurora.org> wrote:
>>
>> Pkshih <pkshih@realtek.com> writes:
>>
>> > Please help to update 8852a firmware.
>> > This is first time I send a pull request. If anything is wrong,
>> > please let me know.
>>
>> rtw89 driver is not in upstream yet, and it has not been reviewed
>> either. I recommend holding off pulling the firmware until the driver is
>> reviewed.
>
> FWIW, preliminary rtw89 firmware was already merged. This is just an update.
>
> I also wonder, what's the harm? People like me are actively testing
> the early versions, and I've done a very barebones amount of review (I
> hope to do more). It really helps me to have up-to-date firmware
> published somewhere central -- I guess I can take GitHub instead, but
> again, why not kernel.org? If anyone else is looking at testing, they
> know where to get the pieces too, and we can compare results.

It can create confusion to the users if during review we make changes
how firmware files are handled. Some drivers have windows style .ini
files which are not ok in an upstream driver, there could be changes in
the file format etc.

But I have no strong opinion here, my main motivation is just to try to
keep things simple for maintaining the "interface" between
linux-firmware and kernel wireless drivers. My preference is that the
firmware files are ready for submission when a new driver is submitted
for review, but the firmware files are submitted only after the driver
is accepted.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches