Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp320899pxj; Thu, 13 May 2021 05:51:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyD9ot0Su4opyXu0gvBQeP6BDLSFSPJfCjcPsuH2PJJYiMCzey3inEud+dDq35qdELRpOIg X-Received: by 2002:aa7:d801:: with SMTP id v1mr50752982edq.349.1620910292726; Thu, 13 May 2021 05:51:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620910292; cv=none; d=google.com; s=arc-20160816; b=SxV1ECVUCnMglEy0id6GoEaldUwWfYsRExWW8M1yhFlwR2otYxPBVQSvbWPR2a2S6H cApR3ptJaluDAngxOPusVNampg3gXsa3SfmgL3pBdcXATSnhj9+SZUSxCwDkFXf2qyyx ZtSE2AOqmF2Hokd0PoaoZYHiDGQqbecYLe1xT652svRSXKueESLvpwoAVBz8OwLDslgx 6CKz5tVefhlfHh8PYFNm8WeH+uFpn6xKtGM/TSKbqIRbuoZPJ4crymdqf3MbzrHey8Dk tCHGuw6PikfhyHVJNcLGyRpO151mC8WU4yhqXfo7gJQovJJovfpT4xb/brPFqcPKB0wD 1JdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=K35gF/xnGkLEm8MMaCxpEH7Y0VHvdS7xExgrz5oaGRg=; b=oPJEPz/L71EwVJL+pIpIlCcGBBtAv8Jp41jSzBSD95MJ7Q1aE43cdp5+TLoTdtoTR1 qHC7JneUs/o0F+DTlT/Rz1kxtyg+Q07fkPpy39VZQGRvl5Clxzrp2tA4TZ/MuQuFM6qG Ob2NYGxPzrMBsPKezYJA2C9LZsoG+e8bjn4eCp+nL8cybJMNMYQEnT9bhZpSemTGc4Gv chH0T9mXv2Uk7J7zcW+4l0UGJ+WY4c8V8uGyTIdvKIvFWPcCLq4t5o+Uz7gUKOMAZb4Z Kj9FHdt2s0Xs8oHO1vpI2kSGauVFfuM1r80urkAY2sJlT+qmiruPufHMMtUI5ax7BMQN GBew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e7si3582243edk.255.2021.05.13.05.51.08; Thu, 13 May 2021 05:51:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233821AbhEMMZe (ORCPT + 99 others); Thu, 13 May 2021 08:25:34 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:34054 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233800AbhEMMZ1 (ORCPT ); Thu, 13 May 2021 08:25:27 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lhANu-0003dX-6U; Thu, 13 May 2021 12:24:10 +0000 From: Colin King To: Ping-Ke Shih , Kalle Valo , "David S . Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] rtlwifi: rtl8723ae: remove redundant initialization of variable rtstatus Date: Thu, 13 May 2021 13:24:09 +0100 Message-Id: <20210513122410.59204-1-colin.king@canonical.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Colin Ian King The variable rtstatus is being initialized with a value that is never read, it is being updated later on. The assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c index f8a1de6e9849..c98f2216734f 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c @@ -915,7 +915,7 @@ int rtl8723e_hw_init(struct ieee80211_hw *hw) struct rtl_phy *rtlphy = &(rtlpriv->phy); struct rtl_ps_ctl *ppsc = rtl_psc(rtl_priv(hw)); struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw)); - bool rtstatus = true; + bool rtstatus; int err; u8 tmp_u1b; unsigned long flags; -- 2.30.2