Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp747741pxj;
        Thu, 13 May 2021 16:17:50 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJwGLIhEE2O4IvLmmWUVmhDc8fgFbkn1jDLWc5UAHFn/c6D8NX1sX7x1oLK/8d20Yp1/VMoD
X-Received: by 2002:a17:907:768c:: with SMTP id jv12mr8591085ejc.215.1620947870484;
        Thu, 13 May 2021 16:17:50 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1620947870; cv=none;
        d=google.com; s=arc-20160816;
        b=gLjMmUnrLwc4+Zxf1Ir2p4DKTuSHLznETUOSHlBETuasIJ7IOjRqTJ5S2QobAalpXn
         ON+x/ES9LY0GPrIgok3hA2wMWr9NKNqFDJK695gslhq6o7UZIkMHJiugEgnQ9w8PI9Av
         5wuAVZ9zIGWuMEZ5+mi5B+hKPMWV6mqpQ7rRgec2qh9gKvwnABmQPi4z0q/EYqdseaBp
         7kh2DCy9ke5lUEr3F6M2QQNcjg8TUu9rw1sHCGEDHPFqeiDmPLAwbDnnVeJc0F+qvmez
         Biv+aIN0piviQ2smrjfctdyq5QlXn1uyK9IpPouzi7KZXSYy0N0fPpxlBRAp+urn7DqA
         yhkA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=YB+x1uWJJXbxDHCJJWi/oKYLuH4rg7wMjIce54jHnIk=;
        b=fscpHllsYkEZ1cPhI6cbegcB//fsiOuLOeM0SZz+KBf6phS0TWKTb0lhRysI6nsvpp
         janRCgtyGrlsoEkXBCcXeWeDNxBN0I7lHhc+7kuDDRZ9Bs6bTpewlxRJivlwHfuqdKpp
         gg44nmjUOqqdOst9jBwW09kxedgMLuMIc0rjQfLR1F/v4GF7YerqMPBZ45/OlQ+IKlNL
         sBUto95dCBmcLUDE6s7AWrDqO4tPdHXkXoITtB9qD5/zpMTlKOEEVuVAtXptg58goXXS
         IcBhQ0pL0ikPFdADGCFVVAh7Tcfk2QiyxHdJnp9dJbRU5t2G/K0BfZ2sPwCGKIhoCJ3z
         +WOw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=2ll+Ro1C;
       spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org
Return-Path: <linux-wireless-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id h25si261144eja.400.2021.05.13.16.17.26;
        Thu, 13 May 2021 16:17:50 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=2ll+Ro1C;
       spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S231905AbhEMS5V (ORCPT <rfc822;mike.rudenko@gmail.com>
        + 99 others); Thu, 13 May 2021 14:57:21 -0400
Received: from mail.kernel.org ([198.145.29.99]:45366 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S231844AbhEMS5V (ORCPT <rfc822;linux-wireless@vger.kernel.org>);
        Thu, 13 May 2021 14:57:21 -0400
Received: by mail.kernel.org (Postfix) with ESMTPSA id B3E36613DF;
        Thu, 13 May 2021 18:56:10 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
        s=korg; t=1620932171;
        bh=YB+x1uWJJXbxDHCJJWi/oKYLuH4rg7wMjIce54jHnIk=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=2ll+Ro1CUt0ktrq8IuZtyJTBkD88MPjAFHtliBR9Fvw1qA3ThF58w3RwaknULOiyh
         AxpaJo3NhPFnp+zzKjlQOtNqG0KXNvW/CfEf8a0el4Qq+SBwa1A+47J8xD0WmqhEih
         SC1DLw0qbvwrEgoHOuB4xuYuAFuPfSojx/HDq12I=
Date:   Thu, 13 May 2021 20:56:09 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Cc:     linux-wireless@vger.kernel.org, johannes.berg@intel.com,
        tomas.winkler@intel.com, luciano.coelho@intel.com,
        Ayala Beker <ayala.beker@intel.com>
Subject: Re: [PATCH v2 2/3] iwlwifi: mei: add the driver to allow cooperation
 with CSME
Message-ID: <YJ12SaLoO40u3lG5@kroah.com>
References: <20210412124328.24472-1-emmanuel.grumbach@intel.com>
 <20210420172755.12178-1-emmanuel.grumbach@intel.com>
 <20210420172755.12178-2-emmanuel.grumbach@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210420172755.12178-2-emmanuel.grumbach@intel.com>
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Tue, Apr 20, 2021 at 08:27:54PM +0300, Emmanuel Grumbach wrote:
> +#define ROUND_UP_TO(x, y) (((x) + (y) - 1) / (y) * (y))

What's wrong with roundup() that the kernel provides?

Please don't reinvent things we already have :(

thanks,

greg k-h