Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210511180259.159598-1-johannes@sipsolutions.net> <20210511200110.9ba2664866a4.I756e47b67e210dba69966d989c4711ffc02dc6bc@changeid>
In-Reply-To: <20210511200110.9ba2664866a4.I756e47b67e210dba69966d989c4711ffc02dc6bc@changeid>
From:   Abhishek Kumar <kuabhs@chromium.org>
Date:   Fri, 14 May 2021 15:23:21 -0700
Message-ID: <CACTWRwvOFV=Yws=ZrR01YCOnzbc4AcXN8+dDK4vEsuc=svv4dg@mail.gmail.com>
Subject: Re: [PATCH 11/18] ath10k: add CCMP PN replay protection for
 fragmented frames for PCIe
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     linux-wireless <linux-wireless@vger.kernel.org>,
        Wen Gong <wgong@codeaurora.org>, stable@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

> +static bool ath10k_htt_rx_h_frag_pn_check(struct ath10k *ar,
> +                                         struct sk_buff *skb,
> +                                         u16 peer_id,
> +                                         u16 offset,
> +                                         enum htt_rx_mpdu_encrypt_type enctype)
> +{
> +       struct ath10k_peer *peer;
> +       union htt_rx_pn_t *last_pn, new_pn = {0};
> +       struct ieee80211_hdr *hdr;
> +       bool more_frags;
The variable more_frags is not getting used.
> +       new_pn.pn48 = ath10k_htt_rx_h_get_pn(ar, skb, offset, enctype);
> +       more_frags = ieee80211_has_morefrags(hdr->frame_control);
"more_frags is assigned here but not used anywhere.

I have raised a patch for remove this, I have raised a patch for this,
https://patchwork.kernel.org/project/linux-wireless/patch/20210514220644.1.Iad576de95836b74aba80a5fc28d7131940eca190@changeid/

-Abhishek