Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1103863pxj; Sat, 15 May 2021 04:05:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxyrFEWA67Zb57dp633P/JNA4ron5Dnzj59DUUlJ8bCtl0WI13lU7Io/E0OBQYKCrVRxUii X-Received: by 2002:a92:d5cd:: with SMTP id d13mr43316236ilq.133.1621076733149; Sat, 15 May 2021 04:05:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621076733; cv=none; d=google.com; s=arc-20160816; b=W6mrHYKW/RT0jmK3zjf/PsvR2dQJSQKXepisbTRwTFSd30327yPLDUoy48IISvxjct /PRrA/rIRC4zYSmrOsDGdVmGkhjNenH56D/kGUPpoRoyNh4v+M/p5fX9SP74ksQo/X+E 00s8K0CSY6gQ8h/+UI6ydD/ZcueRqgjvdjHh2AfqkWUnK+SJXpUxAkEJ79e8Z1CQpivc Uulj2cpWKx7HbFa1NSUpeNK+AAnyHZTPpAViTz2O4FauBGDlpTkjUu0tHMz9LZk0g0lc T6EbrvlAAzHrQJ/Kk98Hrcby+KfLKgEj0VLTXC5B9jp4Hdlas4H9om1sBFs0A0OEIGPX qecQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dmarc-filter:sender :dkim-signature; bh=J4/UV+VBlg6J8gPLAtNX47KgtZ3wzwsbV6BDKY/gyAA=; b=zhQDUbe+jnOAnN6rSv4K1kydeWPn3Dr0ggT0LL4Z2HmWLhkaC/nXkoOIF2NLJ3tUKK GLmCs1L/kWgNrwI5UvcAqueEdzeRMKvJeTNNrTeTEOvtMTbsEW7+OYX7KcuvpR6Nr4MC qqaL/Ptr/danJYKpT7LelsVlP5+Si0AKQIE8X5TNrcDwDLCaV73JgCuOf8A1nnlh28wM 1vcHfibhe0SCuknWfvLExQWq8m6qptTYOibcmj1zcrfFCuKdt5wV/F9VeZp7jCbHi8aQ QiTYMN6KBOZOZIHb57KEh/xK1DhLeSVg1RTuHacxgTTsp0pFyIgTDlmEo4nTWXRscgI4 SJJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=wjWQsnW8; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y3si10352523iom.73.2021.05.15.04.05.19; Sat, 15 May 2021 04:05:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=wjWQsnW8; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230384AbhEOGYf (ORCPT + 99 others); Sat, 15 May 2021 02:24:35 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:49213 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229980AbhEOGY3 (ORCPT ); Sat, 15 May 2021 02:24:29 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1621059797; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=J4/UV+VBlg6J8gPLAtNX47KgtZ3wzwsbV6BDKY/gyAA=; b=wjWQsnW8zAW8Z8S+5F9eTaaQOLgNGfVyOASvDCCb6ljydVUky9WHFL3oNs5XUclD9vUiDL9y RydmJjbgtiV3NA0P4VMnF+3hl90Qwp4HEd0Ccf29/faMoOIkmbQ9lDWfMIU+eZGc3B9PgJj0 HqXmm0qwUDeNCVkNHhYQ0onbLaA= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 609f68cb7b5af81b5c17b37e (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sat, 15 May 2021 06:23:07 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id CAB54C4338A; Sat, 15 May 2021 06:23:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,SPF_FAIL, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id A4786C433D3; Sat, 15 May 2021 06:23:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A4786C433D3 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Arnd Bergmann Cc: linux-arch@vger.kernel.org, Linus Torvalds , Vineet Gupta , Arnd Bergmann , Amitkumar Karwar , Ganapathi Bhat , Sharvari Harisangam , Xinming Hu , "David S. Miller" , Jakub Kicinski , Devidas Puranik , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 10/13] mwifiex: re-fix for unaligned accesses References: <20210514100106.3404011-1-arnd@kernel.org> <20210514100106.3404011-11-arnd@kernel.org> Date: Sat, 15 May 2021 09:22:58 +0300 In-Reply-To: <20210514100106.3404011-11-arnd@kernel.org> (Arnd Bergmann's message of "Fri, 14 May 2021 12:00:58 +0200") Message-ID: <87lf8gikhp.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Arnd Bergmann writes: > From: Arnd Bergmann > > A patch from 2017 changed some accesses to DMA memory to use > get_unaligned_le32() and similar interfaces, to avoid problems > with doing unaligned accesson uncached memory. > > However, the change in the mwifiex_pcie_alloc_sleep_cookie_buf() > function ended up changing the size of the access instead, > as it operates on a pointer to u8. > > Change this function back to actually access the entire 32 bits. > Note that the pointer is aligned by definition because it came > from dma_alloc_coherent(). > > Fixes: 92c70a958b0b ("mwifiex: fix for unaligned reads") > Signed-off-by: Arnd Bergmann Via which tree should this go? I assume it will go via some other tree so: Acked-by: Kalle Valo -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches