Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210514100106.3404011-1-arnd@kernel.org> <20210514100106.3404011-11-arnd@kernel.org>
 <87lf8gikhp.fsf@codeaurora.org>
In-Reply-To: <87lf8gikhp.fsf@codeaurora.org>
From:   Arnd Bergmann <arnd@kernel.org>
Date:   Sat, 15 May 2021 11:01:02 +0200
Message-ID: <CAK8P3a0zc7GGEjPzYsAi=EPxs+3PL0PuhiRF2DfAfR1OHAn+gg@mail.gmail.com>
Subject: Re: [PATCH v2 10/13] mwifiex: re-fix for unaligned accesses
To:     Kalle Valo <kvalo@codeaurora.org>
Cc:     linux-arch <linux-arch@vger.kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Vineet Gupta <vgupta@synopsys.com>,
        Amitkumar Karwar <amitkarwar@gmail.com>,
        Ganapathi Bhat <ganapathi017@gmail.com>,
        Sharvari Harisangam <sharvari.harisangam@nxp.com>,
        Xinming Hu <huxinming820@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Devidas Puranik <devidas@marvell.com>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        Networking <netdev@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        devidas.puranik@nxp.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, May 15, 2021 at 8:22 AM Kalle Valo <kvalo@codeaurora.org> wrote:
> Arnd Bergmann <arnd@kernel.org> writes:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > A patch from 2017 changed some accesses to DMA memory to use
> > get_unaligned_le32() and similar interfaces, to avoid problems
> > with doing unaligned accesson uncached memory.
> >
> > However, the change in the mwifiex_pcie_alloc_sleep_cookie_buf()
> > function ended up changing the size of the access instead,
> > as it operates on a pointer to u8.
> >
> > Change this function back to actually access the entire 32 bits.
> > Note that the pointer is aligned by definition because it came
> > from dma_alloc_coherent().
> >
> > Fixes: 92c70a958b0b ("mwifiex: fix for unaligned reads")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Via which tree should this go? I assume it will go via some other tree
> so:
>
> Acked-by: Kalle Valo <kvalo@codeaurora.org>

I have queued the series in the asm-generic tree for 5.14, as the patches
that depend on this one are a little too invasive for 5.13 at this point.

If you think this fix should be in 5.13, please take it through your tree.

        Arnd