Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1335902pxj; Wed, 19 May 2021 03:50:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxlOX3SqXBiyZdZ1yYo6Ndvrtno8NA2ce9aAoJce1Mwb6JhofQMQJKiNEtsicOPYfmZxm6h X-Received: by 2002:a17:906:4f91:: with SMTP id o17mr11865357eju.219.1621421439812; Wed, 19 May 2021 03:50:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621421439; cv=none; d=google.com; s=arc-20160816; b=KVFPjRhuMgTapn0k3rGtwDFkjot0k15uqxR3XH6eRpTLkVoE4HbCb5h/jP/DHEblIt dtOHxFqk/dUzAVlCJtbw+W2wdT8kmCmK7oQqIJlsVrtjW9zGqw+EEl+0FwpcrMwFDcZg 27vkEUeSciEL/afCyacirum3LCPIn3PSbRIDQfN5HgloTcIxqfHDLMjaM/X9hV3X3YLd 6CRuVt9HBJ/ns7hZ8jytqGPCVeo5rZwL/VPKkf0wnymCgiq2v3Wfq23bkMWrWuB7/qV/ aUJK92FXieGrVNlrS7R2kZ9WZiEytseKfx9XolNrUUFZlE2VQq5ZB2MFe+KtphSm3Jms aSrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=45jMc9MimpovtKlElAPbo7wvPnNU2ZX00kx0iv6uizY=; b=ESxQeQ99MvVMf86pLcPZmW5HoC+teUG0wgtJWdzgUQ+uNwpDlJHHeUkL2bAPfBpurk C2vzrFSXTCOna8zQs7+7hyRnNeN6k4NHIpUPOR8+lzPaomY87KjROOe2NDtoH904v/gr XsjMoCVPGeyCkqGtSF0QVjlxP6ALnHEEC32cy9yzCgjEg3CSf1IFG9AuRH7uik4g4rbo y8sUPLo6W1U3b5dYXrRldjRrvTcI8r2mFHNRUuurPzXV78bdxDojGOOTQHRPZHy7vLND 7vc8E8Li1UCu9FOBEY0XL/q4zGSI1KPGp93f/HRfNELZl5CTCkOBlActGvdX8a4QSgNb 835Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=hisilicon.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ga4si6396546ejc.497.2021.05.19.03.50.15; Wed, 19 May 2021 03:50:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=hisilicon.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239396AbhERCx6 (ORCPT + 99 others); Mon, 17 May 2021 22:53:58 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:3013 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237572AbhERCx5 (ORCPT ); Mon, 17 May 2021 22:53:57 -0400 Received: from dggems704-chm.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4FkgTq6qlszlfZG for ; Tue, 18 May 2021 10:50:23 +0800 (CST) Received: from dggeme759-chm.china.huawei.com (10.3.19.105) by dggems704-chm.china.huawei.com (10.3.19.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Tue, 18 May 2021 10:52:39 +0800 Received: from localhost.localdomain (10.69.192.56) by dggeme759-chm.china.huawei.com (10.3.19.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Tue, 18 May 2021 10:52:38 +0800 From: Tian Tao To: CC: , Tian Tao Subject: [PATCH] ssb: remove unreachable code Date: Tue, 18 May 2021 10:52:32 +0800 Message-ID: <1621306352-3632-1-git-send-email-tiantao6@hisilicon.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.69.192.56] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggeme759-chm.china.huawei.com (10.3.19.105) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org The return value of ssb_bus_unregister can only be 0 or 1, so this condition if (err == -EBUSY) will not hold, so delete it. Signed-off-by: Tian Tao --- drivers/ssb/main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c index 0a26984..8fcf53c 100644 --- a/drivers/ssb/main.c +++ b/drivers/ssb/main.c @@ -431,9 +431,7 @@ void ssb_bus_unregister(struct ssb_bus *bus) int err; err = ssb_gpio_unregister(bus); - if (err == -EBUSY) - pr_debug("Some GPIOs are still in use\n"); - else if (err) + if (err) pr_debug("Can not unregister GPIO driver: %i\n", err); ssb_buses_lock(); -- 2.7.4