Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <b42014d8bfbb6b58fc25656effada37aac066a85.camel@sipsolutions.net>
Subject: Re: [PATCH 1/2] mac80211: do not use low data rates for data frames
 with no ack flag
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Felix Fietkau <nbd@nbd.name>,
        Philipp Borgers <borgers@mi.fu-berlin.de>
Cc:     linux-wireless@vger.kernel.org
Date:   Tue, 18 May 2021 13:19:46 +0200
In-Reply-To: <f80ba91c-88d4-3064-6861-5f9510b4fb69@nbd.name>
References: <20210518110755.43077-1-borgers@mi.fu-berlin.de>
         <f80ba91c-88d4-3064-6861-5f9510b4fb69@nbd.name>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 2021-05-18 at 13:17 +0200, Felix Fietkau wrote:
> 
> Frames with IEEE80211_TX_CTL_HW_80211_ENCAP set have no 802.11 header,
> so please change the check something like this:
> 
> 	if ((info->flags & IEEE80211_TX_CTL_NO_ACK) &&
> 	    ((info->flags & IEEE80211_TX_CTL_HW_80211_ENCAP) ||
> 	     ieee80211_is_data(hdr->frame_control)))

Maybe we should consider some kind of inline helper?

static inline bool ieee80211_is_tx_data(struct sk_buff *skb)
{
	... *info = ...
	... *hdr = (void *)skb->data;

	return (info->flags & IEEE80211_TX_CTL_HW_80211_ENCAP) ||
               ieee80211_is_data(hdr->frame_control);
}


or so?

johannes