Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/2] mac80211: do not use low data rates for data frames
 with no ack flag
To:     Johannes Berg <johannes@sipsolutions.net>,
        Philipp Borgers <borgers@mi.fu-berlin.de>
Cc:     linux-wireless@vger.kernel.org
References: <20210518110755.43077-1-borgers@mi.fu-berlin.de>
 <f80ba91c-88d4-3064-6861-5f9510b4fb69@nbd.name>
 <b42014d8bfbb6b58fc25656effada37aac066a85.camel@sipsolutions.net>
From:   Felix Fietkau <nbd@nbd.name>
Message-ID: <eaf54a94-5d8d-13e2-61e5-23b152fcd3b6@nbd.name>
Date:   Tue, 18 May 2021 13:30:14 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <b42014d8bfbb6b58fc25656effada37aac066a85.camel@sipsolutions.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2021-05-18 13:19, Johannes Berg wrote:
> On Tue, 2021-05-18 at 13:17 +0200, Felix Fietkau wrote:
>> 
>> Frames with IEEE80211_TX_CTL_HW_80211_ENCAP set have no 802.11 header,
>> so please change the check something like this:
>> 
>> 	if ((info->flags & IEEE80211_TX_CTL_NO_ACK) &&
>> 	    ((info->flags & IEEE80211_TX_CTL_HW_80211_ENCAP) ||
>> 	     ieee80211_is_data(hdr->frame_control)))
> 
> Maybe we should consider some kind of inline helper?
> 
> static inline bool ieee80211_is_tx_data(struct sk_buff *skb)
> {
> 	... *info = ...
> 	... *hdr = (void *)skb->data;
> 
> 	return (info->flags & IEEE80211_TX_CTL_HW_80211_ENCAP) ||
>                ieee80211_is_data(hdr->frame_control);
> }
> 
> 
> or so?
Yes, I think that's a good idea. There will definitely be more places
that need this.

- Felix