Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 19 May 2021 12:47:32 +0200
From:   Philipp Borgers <borgers@mi.fu-berlin.de>
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     Felix Fietkau <nbd@nbd.name>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] mac80211: do not use low data rates for data frames
 with no ack flag
Message-ID: <YKTsxD+E6MnFzQ5C@mi.fu-berlin.de>
References: <20210518110755.43077-1-borgers@mi.fu-berlin.de>
 <f80ba91c-88d4-3064-6861-5f9510b4fb69@nbd.name>
 <b42014d8bfbb6b58fc25656effada37aac066a85.camel@sipsolutions.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: 8BIT
In-Reply-To: <b42014d8bfbb6b58fc25656effada37aac066a85.camel@sipsolutions.net>
Precedence: bulk

On Tue, May 18, 2021 at 01:19:46PM +0200, Johannes Berg wrote:
> On Tue, 2021-05-18 at 13:17 +0200, Felix Fietkau wrote:
> > 
> > Frames with IEEE80211_TX_CTL_HW_80211_ENCAP set have no 802.11 header,
> > so please change the check something like this:
> > 
> > 	if ((info->flags & IEEE80211_TX_CTL_NO_ACK) &&
> > 	    ((info->flags & IEEE80211_TX_CTL_HW_80211_ENCAP) ||
> > 	     ieee80211_is_data(hdr->frame_control)))
> 
> Maybe we should consider some kind of inline helper?
> 
> static inline bool ieee80211_is_tx_data(struct sk_buff *skb)
> {
> 	... *info = ...
> 	... *hdr = (void *)skb->data;
> 
> 	return (info->flags & IEEE80211_TX_CTL_HW_80211_ENCAP) ||
>                ieee80211_is_data(hdr->frame_control);
> }

A frame with IEEE80211_TX_CTL_HW_80211_ENCAP set is always a data frame?

Should I put the definition of the function into include/net/mac80211.h?