Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 20 May 2021 20:17:31 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Bhaumik Bhatt <bbhatt@codeaurora.org>
Cc:     Kalle Valo <kvalo@codeaurora.org>,
        Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
        Loic Poulain <loic.poulain@linaro.org>,
        ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
        regressions@lists.linux.dev, stable@vger.kernel.org
Subject: Re: [regressions] ath11k: v5.12.3 mhi regression
Message-ID: <YKanuzzvDhztYxm/@kroah.com>
References: <87v97dhh2u.fsf@codeaurora.org>
 <YKYzwBJNTy4Czd1A@kroah.com>
 <20210520104313.GA128703@thinkpad>
 <87r1i1h9an.fsf@codeaurora.org>
 <3e8bac3b02e3549a55b7c9b78b699965@codeaurora.org>
 <YKajWVPUSTzNVVm8@kroah.com>
 <608474b9b9feae5bd0616ad16d6d6bbd@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <608474b9b9feae5bd0616ad16d6d6bbd@codeaurora.org>
Precedence: bulk

On Thu, May 20, 2021 at 11:04:05AM -0700, Bhaumik Bhatt wrote:
> On 2021-05-20 10:58 AM, Greg KH wrote:
> > On Thu, May 20, 2021 at 10:38:12AM -0700, Bhaumik Bhatt wrote:
> > > On 2021-05-20 05:36 AM, Kalle Valo wrote:
> > > > Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> writes:
> > > >
> > > > > On Thu, May 20, 2021 at 12:02:40PM +0200, Greg KH wrote:
> > > > > > On Thu, May 20, 2021 at 12:47:53PM +0300, Kalle Valo wrote:
> > > > > > > Hi,
> > > > > > >
> > > > > > > I got several reports that this mhi commit broke ath11k in v5.12.3:
> > > > > > >
> > > > > > > commit 29b9829718c5e9bd68fc1c652f5e0ba9b9a64fed
> > > > > > > Author: Bhaumik Bhatt <bbhatt@codeaurora.org>
> > > > > > > Date:   Wed Feb 24 15:23:04 2021 -0800
> > > > > > >
> > > > > > >     bus: mhi: core: Process execution environment changes serially
> > > > > > >
> > > > > > >     [ Upstream commit ef2126c4e2ea2b92f543fae00a2a0332e4573c48 ]
> > > > > > >
> > > > > > > Here are the reports:
> > > > > > >
> > > > > > > https://bugzilla.kernel.org/show_bug.cgi?id=213055
> > > > > > >
> > > > > > > https://bugzilla.kernel.org/show_bug.cgi?id=212187
> > > > > > >
> > > > > > > https://bugs.archlinux.org/task/70849?project=1&string=linux
> > > > > > >
> > > > > > > Interestingly v5.13-rc1 seems to work fine, at least for me, though I
> > > > > > > have not tested v5.12.3 myself. Can someone revert this commit in the
> > > > > > > stable release so that people get their wifi working again, please?
> > > > > >
> > > > > > How does the mhi bus code relate to a ath11k driver?  What bus
> > > > > > is that
> > > > > > on?
> > > > > >
> > > > >
> > > > > MHI is the transport used by the ath11k driver to work with the WLAN
> > > > > devices
> > > > > over PCIe.
> > > > >
> > > > > Regarding the bug, I'd suggest to wait for Bhaumik (the author of
> > > > > 29b9829718c5)
> > > > > to comment on the possible commit which needs backporting from
> > > > > mainline.
> > > >
> > > > Ok, but if a quick fix is not available I think we should just revert
> > > > this in the stable releases. I also got a report that v5.11.21 is
> > > > broken:
> > > >
> > > > https://bugzilla.kernel.org/show_bug.cgi?id=213055#c11
> > > 
> > > Please pick [1] as the dependency to [ Upstream commit
> > > ef2126c4e2ea2b92f543fae00a2a0332e4573c48 ].
> > 
> > what is [1]???
> > 
> > What commit do I need to backport, a commit id would be nice...
> > 
> > thanks,
> > 
> > greg k-h
> Sure Greg. Commit id is: 4884362f6977fc05cbec736625665241c0e0732f
> 
> Title of patch:
> bus: mhi: core: Download AMSS image from appropriate function
> 
> It was supposed to be a link but not sure why it's not seen.

Text email doesn't have links :)

Anyway, thanks, now queued up.

Also note, it's nice to write kernel commit ids as 4884362f6977 ("bus:
mhi: core: Download AMSS image from appropriate function") which is the
preferred way to reference them in a emails and commit logs.

thanks,

greg k-h