Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] ssb: remove unreachable code
To:     =?UTF-8?Q?Michael_B=c3=bcsch?= <m@bues.ch>,
        Tian Tao <tiantao6@hisilicon.com>
CC:     <linux-wireless@vger.kernel.org>, Kalle Valo <kvalo@codeaurora.org>
References: <1621306352-3632-1-git-send-email-tiantao6@hisilicon.com>
 <20210520185136.2cc3b32b@wiggum>
From:   "tiantao (H)" <tiantao6@huawei.com>
Message-ID: <0a40049b-691c-c75f-ece2-a669842bedaf@huawei.com>
Date:   Fri, 21 May 2021 08:49:42 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20210520185136.2cc3b32b@wiggum>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2021/5/21 0:51, Michael Büsch 写道:
> On Tue, 18 May 2021 10:52:32 +0800
> Tian Tao <tiantao6@hisilicon.com> wrote:
>
>> The return value of ssb_bus_unregister can only be 0 or 1, so this
>> condition if (err == -EBUSY) will not hold, so delete it.
>> @@ -431,9 +431,7 @@ void ssb_bus_unregister(struct ssb_bus *bus)
>>   	int err;
>>   
>>   	err = ssb_gpio_unregister(bus);
>> -	if (err == -EBUSY)
>> -		pr_debug("Some GPIOs are still in use\n");
>> -	else if (err)
>> +	if (err)
>>   		pr_debug("Can not unregister GPIO driver: %i\n", err);
>>   
>>   	ssb_buses_lock();
> Good catch.
> Minor correction: The return value can be 0 or -1.
yes, you are right. thanks again.:-)
>
> Acked-by: Michael Büsch <m@bues.ch>
>