Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 7E80BC433D3
From:   Kalle Valo <kvalo@codeaurora.org>
To:     "tiantao \(H\)" <tiantao6@huawei.com>
Cc:     Michael =?utf-8?Q?B=C3=BCsch?= <m@bues.ch>,
        Tian Tao <tiantao6@hisilicon.com>,
        <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ssb: remove unreachable code
References: <1621306352-3632-1-git-send-email-tiantao6@hisilicon.com>
        <20210520185136.2cc3b32b@wiggum>
        <0a40049b-691c-c75f-ece2-a669842bedaf@huawei.com>
Date:   Fri, 21 May 2021 06:36:07 +0300
In-Reply-To: <0a40049b-691c-c75f-ece2-a669842bedaf@huawei.com> (tiantao's
        message of "Fri, 21 May 2021 08:49:42 +0800")
Message-ID: <87mtsohi6w.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

"tiantao (H)" <tiantao6@huawei.com> writes:

> =E5=9C=A8 2021/5/21 0:51, Michael B=C3=BCsch =E5=86=99=E9=81=93:
>> On Tue, 18 May 2021 10:52:32 +0800
>> Tian Tao <tiantao6@hisilicon.com> wrote:
>>
>>> The return value of ssb_bus_unregister can only be 0 or 1, so this
>>> condition if (err =3D=3D -EBUSY) will not hold, so delete it.
>>> @@ -431,9 +431,7 @@ void ssb_bus_unregister(struct ssb_bus *bus)
>>>   	int err;
>>>     	err =3D ssb_gpio_unregister(bus);
>>> -	if (err =3D=3D -EBUSY)
>>> -		pr_debug("Some GPIOs are still in use\n");
>>> -	else if (err)
>>> +	if (err)
>>>   		pr_debug("Can not unregister GPIO driver: %i\n", err);
>>>     	ssb_buses_lock();
>> Good catch.
>> Minor correction: The return value can be 0 or -1.
>
> yes, you are right. thanks again.:-)

I'll fix the commit log to match that.

--=20
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc=
hes