Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1820218pxj; Sat, 22 May 2021 02:54:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxz5fupuTvq7ZOXjtiV6IwFt62xIRqx5OzMhMIBfeMdErUrh0EQkViVR2vI6jYuA7N9YxHc X-Received: by 2002:a02:b890:: with SMTP id p16mr10835414jam.72.1621677241915; Sat, 22 May 2021 02:54:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621677241; cv=none; d=google.com; s=arc-20160816; b=GoYbU/kcefj5rbLEIc2lHYIjaUiMRsSRTSOJVz0jfTCYSXERcKNJANGMqfNyUaKNgt 8C5vPM01TdGtCuLfwCk3AiAITOShNZPdJA4C6uqS0OZRjms8ukB2xtEWAwi96KIbSnB6 +3EnM0I2CUeQTTI8z2jJDfrsfWElwZBz7u5CvZl01gfgdXwbBZhgyPLtbKY+w/G8dQ6e GV30jf17FEAMw0pAmuiyP5ipFcuuM5c6ha96rOvY6v39lV+lLNEKQWIY2CiFCGxzOrh9 O5NrPpW9Hsi9CG2dbaANLiV3uTlkgWbVM72OvmB7hiEWu0nI4PJ38sseGNiLC1jPgaI2 vWzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=6ymeZkKOXsAgSgZMe7yXMaLic9U0Ma+obPKDFUgBF/Y=; b=sa3QcD2EzEJDUwDd5BxoQEkqiwgaDNcdNXV15Z/xJUQQX86vCUDQfKWs9vV0kC+Dts OuA2gvaWk1Q564dee6Ylel3me1r0JtO+2Ha+TFLvzLgJiOqEFH0zZdvO4k/+m1XXq7oF 5Nq5rvUV/qFu33nc5MK9gGioFLm2idxt6pWYITMUrL1MjVFiIvRxxlNUAkbBcmnq+LIc Rev+txYiJhRrU6HkDfMCen2G0sTJ4RkputfThVrqieWLnwft+lWfbytPJpxoEQWG9NB+ l7SkA7rJJ5mnXnMA1VoJty7RHJ1t6BMiOxEag5i6XwXpmDZTh/lRkukmeSBcYDMq04AQ sU3w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j188si9474188jac.58.2021.05.22.02.53.45; Sat, 22 May 2021 02:54:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230255AbhEVJw0 (ORCPT + 99 others); Sat, 22 May 2021 05:52:26 -0400 Received: from smtp05.smtpout.orange.fr ([80.12.242.127]:52503 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230185AbhEVJw0 (ORCPT ); Sat, 22 May 2021 05:52:26 -0400 Received: from localhost.localdomain ([86.243.172.93]) by mwinf5d40 with ME id 7lqu2500J21Fzsu03lqumV; Sat, 22 May 2021 11:51:00 +0200 X-ME-Helo: localhost.localdomain X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sat, 22 May 2021 11:51:00 +0200 X-ME-IP: 86.243.172.93 From: Christophe JAILLET To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org, bperumal@codeaurora.org, akolli@codeaurora.org, milehu@codeaurora.org, lkp@intel.com Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: [PATCH] ath11k: Fix an error handling path in 'ath11k_core_fetch_board_data_api_n()' Date: Sat, 22 May 2021 11:50:54 +0200 Message-Id: X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org All error paths but this one 'goto err' in order to release some resources. Fix this. Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices") Signed-off-by: Christophe JAILLET --- drivers/net/wireless/ath/ath11k/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c index 77ce3347ab86..595e83fe0990 100644 --- a/drivers/net/wireless/ath/ath11k/core.c +++ b/drivers/net/wireless/ath/ath11k/core.c @@ -488,7 +488,8 @@ static int ath11k_core_fetch_board_data_api_n(struct ath11k_base *ab, if (len < ALIGN(ie_len, 4)) { ath11k_err(ab, "invalid length for board ie_id %d ie_len %zu len %zu\n", ie_id, ie_len, len); - return -EINVAL; + ret = -EINVAL; + goto err; } switch (ie_id) { -- 2.30.2