Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4253704pxj; Tue, 25 May 2021 03:57:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwbn2Tu4kYiHhy0De0EAqrsViGb1gcZiglxa/NOc+nUo2V+tABdQGcTiN0nqDohd3erKb6K X-Received: by 2002:a17:907:3ea0:: with SMTP id hs32mr28084587ejc.475.1621940271479; Tue, 25 May 2021 03:57:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621940271; cv=none; d=google.com; s=arc-20160816; b=wTAWDh5Mg5KWQwJARJlAFfa3S/RLl925EDciv7lQu11zE4n3X2PC3wJfLUbaocNN72 Rh8EhaL+JVynlmdeeP0mIJlr+dW8AIXTaaQ4sAIVrmK5ZPrH0hchOJPkxnQRJzzhKm1x BvZ+6vp1cmijRdgzX3eRwNyiQoUPsVR98whKWPspW2O/osuRcOhTONWzma5A8wPElu0p /iS8aI/duzoV61FyRyK+QlrhiZzo0GdfBFaoOiO2IkG7ThDXlOZqO3IxmhXN04beRBAh 6yH5LX00z8H4oZdHzZwNoVl46dEf/K3aShxS/vP28JpB9r2KArwvV6xIxb/+hYgx1p/p Ufhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=oT5dxHqV+IGYOFQ5Wabqla864lGWpnRtl1XGuF9BZRk=; b=i7HkoRiNRUxUTRIa3MrsjlbL54CF2SOd1mbwnuoV96zh+ySSUgz7uKqcdIVKkff1No tRAcKdILyB5EQK2xEQbz8BtIKoSDxUPTwx08wljHB31J/F9u5rI2c7ijo/Ip4hEP6V5i MMRVITx7hqll5Z6B+hsLACEUdEnvp204pZkUUenYGNAm/KoeesBCfTXS1Vmxp6uZv6H4 dnwcDkOAZAkpXad+b0O1FA9klvhg3RLXFApnrBE8dv86UDTirQ5Zz1rO8PBFjHALY/Ms YmengmiHnsSFdRk0BCieFQ/uOmTcKN0XLAuGtr9e/ZZiEGcA27t5sXGlxPhkY+OwL9kY LE4Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a15si14338259edr.48.2021.05.25.03.57.28; Tue, 25 May 2021 03:57:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230480AbhEYKrx (ORCPT + 99 others); Tue, 25 May 2021 06:47:53 -0400 Received: from out30-45.freemail.mail.aliyun.com ([115.124.30.45]:44398 "EHLO out30-45.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229968AbhEYKrw (ORCPT ); Tue, 25 May 2021 06:47:52 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R551e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04420;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0Ua4PKOY_1621939578; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0Ua4PKOY_1621939578) by smtp.aliyun-inc.com(127.0.0.1); Tue, 25 May 2021 18:46:20 +0800 From: Yang Li To: davem@davemloft.net Cc: kuba@kernel.org, kvalo@codeaurora.org, ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Li Subject: [PATCH] ath10k: Fix an error code in ath10k_add_interface() Date: Tue, 25 May 2021 18:46:17 +0800 Message-Id: <1621939577-62218-1-git-send-email-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org When the code execute this if statement, the value of ret is 0. However, we can see from the ath10k_warn() log that the value of ret should be -EINVAL. Clean up smatch warning: drivers/net/wireless/ath/ath10k/mac.c:5596 ath10k_add_interface() warn: missing error code 'ret' Reported-by: Abaci Robot Fixes: 'commit ccec9038c721 ("ath10k: enable raw encap mode and software crypto engine")' Signed-off-by: Yang Li --- drivers/net/wireless/ath/ath10k/mac.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index 5ce4f8d..c272b29 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -5592,6 +5592,7 @@ static int ath10k_add_interface(struct ieee80211_hw *hw, if (arvif->nohwcrypt && !test_bit(ATH10K_FLAG_RAW_MODE, &ar->dev_flags)) { + ret = -EINVAL; ath10k_warn(ar, "cryptmode module param needed for sw crypto\n"); goto err; } -- 1.8.3.1