Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4343053pxj; Tue, 25 May 2021 06:02:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxIw50ktBsHM9jK9sFoQX9kRq/nP3eFU7x1zHnpAmTlJWNs1nlCNVnjCokofnR7dlF0yq1N X-Received: by 2002:a05:6e02:b4b:: with SMTP id f11mr23482414ilu.253.1621947724533; Tue, 25 May 2021 06:02:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621947724; cv=none; d=google.com; s=arc-20160816; b=HWcopimVqu2HEjnkiaE91AJv6cRecZKLViRE5Z5e+PDf8RngEatOD8IIxsDRe9cgKd ZGGH2caDf8o8TpXsxSAqG9LIyIfFGQUxGF7eI+511a6XT/aqHPirHPBj7AJSNDlMSFeG IhVJC1XKHKk6C9jqKLeyOKf5IDSgxjr+nsI3ZSrHAkLi49t4To5dLWOPo4k8/dA8sTg/ 2yU9C1aIMMcv/wciV9Dw1j5DN1MnNbf+GhSXYenVDF3bfsqOqbQdpUXgHpSACgUwWFAe HB/cKhPVB29aqubuQ2YKODjKNTAmia51O3xJodg3nXVEY8Yl36sJ/GVVxSIVWNrowiQs 6yew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=Pu/QrHHuSNC4VR4p8ngcTPifICqT/W5/ZVTCEWFFO/A=; b=oUuj9YJOf7taBj1X8utuHSTpMoMtdwm3TV0xYfHT2cjjbxNqWBpAaCFvzOkrBYQuo/ Rd/PmKo4nJ1yifQU+BzIwNp/oScq0NNVCcxRoAcJ5NWM04KVu4WzvIXWmLlcmgTQkkQj nlMRyJeBkMxE6q51Kfyjdq53/NcPKDrZ7rgmEJcqHWP1g43vWLpOvTMirFDHAVkol57r SRL6Sm4LFDMH6eVqDiPGRmd2wpWucuLzkyiznNg0FQJsxLHAgMzBUJm7w1PqTy5x0dCN 67yfltaBO7ssv8oNUeHCRDnKzvBFgkz/bMHoHMRgZaSlZMC4G6IdjAZxSkaDMH92FBIH 3rYw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i17si15660472ioi.33.2021.05.25.06.01.49; Tue, 25 May 2021 06:02:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232986AbhEYNCT (ORCPT + 99 others); Tue, 25 May 2021 09:02:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232992AbhEYNCR (ORCPT ); Tue, 25 May 2021 09:02:17 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6665DC061574 for ; Tue, 25 May 2021 06:00:47 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1llWfo-00EOlC-PS; Tue, 25 May 2021 15:00:40 +0200 Message-ID: <47f9c5c2a9c5fd666751e01799a9a167d8776a49.camel@sipsolutions.net> Subject: Re: [RFC PATCH 2/4] mac80211: minstrel_ht: fix minstrel_aggr_check for encap offload From: Johannes Berg To: Ryder Lee , Felix Fietkau Cc: Lorenzo Bianconi , Shayne Chen , Evelyn Tsai , Bo Jiao , Sujuan Chen , linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org Date: Tue, 25 May 2021 15:00:39 +0200 In-Reply-To: <4e50d38c98c407825c6897a034fee3ba6366b0ad.1621453091.git.ryder.lee@mediatek.com> (sfid-20210519_215642_904470_7AA3F138) References: <4e50d38c98c407825c6897a034fee3ba6366b0ad.1621453091.git.ryder.lee@mediatek.com> (sfid-20210519_215642_904470_7AA3F138) Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Thu, 2021-05-20 at 03:56 +0800, Ryder Lee wrote: > > + if (!(info->flags & IEEE80211_TX_CTL_HW_80211_ENCAP) && > + unlikely(!ieee80211_is_data_qos(hdr->frame_control))) >   return; That unlikely() placement seems odd? johannes