Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp462663pxj; Thu, 27 May 2021 04:36:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJya3ZIzCYfwoAV6blxDCN9KY6RxVl60R3/dJyTwbsrEniDZcx8wAjGNSg+8Z7sn1pWl83Yc X-Received: by 2002:a6b:7d0b:: with SMTP id c11mr2445159ioq.8.1622115409462; Thu, 27 May 2021 04:36:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622115409; cv=none; d=google.com; s=arc-20160816; b=h32LTYvfcX6TsmgoUXqEhP14bCE8zxDpoN2q7sCf6ASRnTHsduEU81rLJPFIEWOSdE 8ISRdydg91muZeX0MFlv8kOsqAnGIkHQV2y2BuOvHBKnawA1NUWPbxCXff/NpyamcTAp TTuWi3Qn799h4INCIVhn2luPuYI4VuIPQ+HRFlg67sBVXS0RUl2hQAq8Wy2AkrXi+Trg 5p2DXj5yU0Dkm9aHwYH3URVafRgcCJQC0Ke4flTz0pYiYWtTazJe8olpe6kdI6+jUFKy IAScPUMzxMZUwTQuY5RHr6GE/iIuYWii8eU36KU6+d4MysiT6919Qp9j/TBvNfqGe3+b QTZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=0nZASYhi/W28cHkACdvQKfMGDAhVqFblmTQ2jgwA9IQ=; b=nx8nimQ0r0UKQ40+jlSC5xWQG71C0PbqJEsIIpdKYMtm2hg90XOkFsglOvJqzQzoOw fEk0Sc88DdKY8Sn3ArTqZFOeSGkZFOMVfjSzG+NnGQI3BU7Eu8ASPk687N8ljihJl11q TqEdeskMhANB8+h4rn1g5qdiYZTGMOyqsupBkpR9AAhUtbFT0N5yvnn3IQRGMgBxX4U3 DR6LwumMIsEzBot1wQT9Xu3zgOQwvbuapFFVJFAc/lQS6KVAtogVJgy9dfLnjLpD9FcG 8qYpk0lVQC5pHV1hsiaEX6XAHJ8Re87aKv7yghss7V7tcBVHFf/DffA65QZ8a0rCkQFl R0SA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AJ7HAD46; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b1si2040981ioh.94.2021.05.27.04.36.36; Thu, 27 May 2021 04:36:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AJ7HAD46; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233040AbhE0LhR (ORCPT + 99 others); Thu, 27 May 2021 07:37:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:46008 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233825AbhE0LhQ (ORCPT ); Thu, 27 May 2021 07:37:16 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B1AEB613D3; Thu, 27 May 2021 11:35:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622115343; bh=TJknkpMyZT/wY84jq9Xil6QwGq+ffNfouQm2ahZK/m8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AJ7HAD46Ii3KYzgrM3dvPRKqJ4D2MoUSXe+kCW82Z3XRxuXmuBiEFCj5knBMXo3N9 0Rw0cpPJqUpolhT+LrxbWtA9XoL3CyFLKEo7ft7y5HFEgct/dLxmu5fxGPVGtP3ENn zm9KEyAiP97acDkGCaOkAHmW8l2+reUeJ+8qdJKE98Q7wAwqylb/0W7x/F6zZu42p0 aFQBX3PplXZZRezyx2HQMem34fhbx5Qj5LSDlvgx7c0mDOjL2+mTEslO40Gd1D20fL z8P6vrRpzv/uLzwTvXhP98mZMkvCPBrqPPx3bVUISmiRmmZElNeUOHKl3zIZIxixi+ 55vAVAR0wfvXg== From: Lorenzo Bianconi To: nbd@nbd.name Cc: lorenzo.bianconi@redhat.com, linux-wireless@vger.kernel.org, shayne.chen@mediatek.com, ryder.lee@mediatek.com Subject: [PATCH 3/3] mt76: testmode: remove undefined behaviour in mt76_testmode_alloc_skb Date: Thu, 27 May 2021 13:35:30 +0200 Message-Id: <1892c389b06aabc59ff9e01d53fc14cf0097c17d.1622115194.git.lorenzo@kernel.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Get rif of an undefined behaviour in mt76_testmode_alloc_skb routine allocating skb frames Fixes: 2601dda8faa76 ("mt76: testmode: add support to send larger packet") Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/testmode.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/testmode.c b/drivers/net/wireless/mediatek/mt76/testmode.c index c516469278a4..c6a85a0cfc89 100644 --- a/drivers/net/wireless/mediatek/mt76/testmode.c +++ b/drivers/net/wireless/mediatek/mt76/testmode.c @@ -159,12 +159,8 @@ int mt76_testmode_alloc_skb(struct mt76_phy *phy, u32 len) head->len += frag->len; head->data_len += frag->len; - if (*frag_tail) { - (*frag_tail)->next = frag; - frag_tail = &frag; - } else { - *frag_tail = frag; - } + *frag_tail = frag; + frag_tail = &(*frag_tail)->next; } mt76_testmode_free_skb(phy); -- 2.31.1