Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 3/4] mac80211: add rate control support for encap
 offload
To:     Ryder Lee <ryder.lee@mediatek.com>, Felix Fietkau <nbd@nbd.name>,
        Johannes Berg <johannes.berg@intel.com>
Cc:     Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
        Shayne Chen <shayne.chen@mediatek.com>,
        Evelyn Tsai <evelyn.tsai@mediatek.com>,
        Bo Jiao <bo.jiao@mediatek.com>,
        Sujuan Chen <sujuan.chen@mediatek.com>,
        linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org
References: <2176023d8f13d82d093452e1c105609396c30622.1622164961.git.ryder.lee@mediatek.com>
 <d447c18f07fe3dc7092f5502de3e35e6b7ae69e1.1622164961.git.ryder.lee@mediatek.com>
From:   Arend van Spriel <arend.vanspriel@broadcom.com>
Message-ID: <489e6d51-c3f0-452d-ab63-ba83bba7ec02@broadcom.com>
Date:   Fri, 28 May 2021 12:46:38 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.2
MIME-Version: 1.0
In-Reply-To: <d447c18f07fe3dc7092f5502de3e35e6b7ae69e1.1622164961.git.ryder.lee@mediatek.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/28/2021 8:05 AM, Ryder Lee wrote:
> The software rate control cannot deal with encap offload, so fix it.
> 
> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> ---
> change since v2 - none
> ---
>   net/mac80211/ieee80211_i.h |  9 +++++++++
>   net/mac80211/rate.c        |  9 ++-------
>   net/mac80211/tx.c          | 18 ++++++++++++++----
>   3 files changed, 25 insertions(+), 11 deletions(-)

[...]

> diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
> index d3016c3a3069..0a4bc9e08637 100644
> --- a/net/mac80211/tx.c
> +++ b/net/mac80211/tx.c

[...]

> @@ -729,7 +730,8 @@ ieee80211_tx_h_rate_ctrl(struct ieee80211_tx_data *tx)
>   		 "%s: Dropped data frame as no usable bitrate found while "
>   		 "scanning and associated. Target station: "
>   		 "%pM on %d GHz band\n",
> -		 tx->sdata->name, hdr->addr1,
> +		 tx->sdata->name,
> +		 encap ? ((struct ethhdr *)hdr)->h_dest : hdr->addr1,
>   		 info->band ? 5 : 2))

Not related to this change, but I guess the band can also be 6 these days.

Regards,
Arend