Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210529071523.2044-1-rdunlap@infradead.org>
In-Reply-To: <20210529071523.2044-1-rdunlap@infradead.org>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Sat, 29 May 2021 14:10:28 +0200
Message-ID: <CAK8P3a2mmQvsK+geQCGAOjZ4r2S9E4AUkWaT2coKW2AL8ZOAYg@mail.gmail.com>
Subject: Re: [PATCH] wireless: carl9170: fix LEDS build errors & warnings
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        kernel test robot <lkp@intel.com>,
        Kalle Valo <kvalo@codeaurora.org>,
        Christian Lamparter <chunkeey@googlemail.com>,
        linux-wireless <linux-wireless@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, May 29, 2021 at 9:16 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> kernel test robot reports over 200 build errors and warnings
> that are due to this Kconfig problem when CARL9170=m,
> MAC80211=y, and LEDS_CLASS=m.

I think this avoids the build problems, but it's not really logical:

> --- linux-next-20210528.orig/drivers/net/wireless/ath/carl9170/Kconfig
> +++ linux-next-20210528/drivers/net/wireless/ath/carl9170/Kconfig
> @@ -17,9 +17,7 @@ config CARL9170
>  config CARL9170_LEDS
>         bool "SoftLED Support"
>         depends on CARL9170
> -       select MAC80211_LEDS
> -       select LEDS_CLASS
> -       select NEW_LEDS
> +       select MAC80211_LEDS if LEDS_CLASS=y || LEDS_CLASS=MAC80211
>         default y
>         help
>           This option is necessary, if you want your device' LEDs to blink

The point of the option is to enable LED support, but now it doesn't do that
when LEDS_CLASS is a loadable module and MAC80211 is built-in.

I think a more sensible solution would be to follow the example of

config MT76_LEDS
        bool
        depends on MT76_CORE
        depends on LEDS_CLASS=y || MT76_CORE=LEDS_CLASS
        default y

    Arnd