Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2889200pxj; Mon, 31 May 2021 13:47:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwkcUWpapxa1r7PjQdq+4ZtVJm6TrQrMvOaCuI2kHtHm4VMus/2p9oVXt9/fk5X8zysHvHB X-Received: by 2002:a05:6638:b84:: with SMTP id b4mr21637401jad.122.1622494049878; Mon, 31 May 2021 13:47:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622494049; cv=none; d=google.com; s=arc-20160816; b=HwjHULXzt2vifPk03hPp8Q6G0SGll365GhMFQMPqATNoGcATEV0h+G0v7uY27OK8er +77SAsw5UJs/OF7cKEhcfcAyexL1Vf1eCFGoL62vTyx+Sl0MJH6VBS1hY2e+OtNafb96 kfx8y/KJeS/gKdqHnBZcz2oDmFH5bqbAkJfUUSp2K8NpnNxuCgw6kLOPCyRuKrP9uKoc XEwos84thTYnHrvECPCBmeBWJJEqSkpyrbCiHAJMNYcRCF9ipDfnIRQ2CfLazfdfVBnD PZkCjfbSEAJ+1ZzvjUwpyVG5/glgcs/szhxxZ9PiCos0EbYoeP5thm2k+o1NIoKlFuka TB8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=FEk4Xkzpg2KBKzoyToe+r9+LUP98N4Ygcmx92yYb4ek=; b=HtmF4i4Crbj6utWq52I24tzk2Gfh1nfahQMcGgHFsuYhPoFVLIx7T+avHYsKyxNGid xSrcm7qDPxEGYQp9PapzjIf5ihKkjHMe218avwwCZPzMqeAveqab9BE0C6RqQ0TzTW4N XMNZTTC2TfWXAGyWJ5ARL8bN6Pv8CC74iO+Qf6pV9/lBF9ToZeK/qaZH7XZyk9M9Oc4N XqxYJKptCWre5FfIsIWUbTaHkBiDGjZeQa7JDYciMySfnojVvqkOVU9Alk/VzZMbHKZX p8qI4gc0/VtFA6yrIZKul9b5KN6WmKTBMSPeoyQFELLvW/uyg0tvaWh1CU33EjnKNml0 dDZg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i9si4565081ila.58.2021.05.31.13.47.11; Mon, 31 May 2021 13:47:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231825AbhEaUso (ORCPT + 99 others); Mon, 31 May 2021 16:48:44 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:53560 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231144AbhEaUsm (ORCPT ); Mon, 31 May 2021 16:48:42 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id F3A611C0B76; Mon, 31 May 2021 22:47:00 +0200 (CEST) Date: Mon, 31 May 2021 22:47:00 +0200 From: Pavel Machek To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Anirudh Rayabharam , Kangjie Lu , Kalle Valo , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH AUTOSEL 4.4 07/16] ath6kl: return error code in ath6kl_wmi_set_roam_lrssi_cmd() Message-ID: <20210531204700.GA19694@amd> References: <20210524145130.2499829-1-sashal@kernel.org> <20210524145130.2499829-7-sashal@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5vNYLRcllDrimb99" Content-Disposition: inline In-Reply-To: <20210524145130.2499829-7-sashal@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org --5vNYLRcllDrimb99 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > From: Anirudh Rayabharam >=20 > [ Upstream commit fc6a6521556c8250e356ddc6a3f2391aa62dc976 ] >=20 > ath6kl_wmi_cmd_send could fail, so let's return its error code > upstream. Something went very wrong here. Content is okay, but "upstream commit" label is wrong, pointing to incomplete fix that was reverted (with different content and different author). commit fc6a6521556c8250e356ddc6a3f2391aa62dc976 Author: Kangjie Lu Date: Wed Dec 26 00:43:28 2018 -0600 ath6kl: return error code in ath6kl_wmi_set_roam_lrssi_cmd() ath6kl_wmi_cmd_send could fail, so let's return its error code upstream. Signed-off-by: Kangjie Lu Signed-off-by: Kalle Valo Best regards, Pavel =09 --=20 DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany --5vNYLRcllDrimb99 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmC1S0QACgkQMOfwapXb+vIeoACfSepaPc6dfkU2aKXHkCAHXiqg bAAAoK/3j/SpCoKfqGlIDdZZmjO8GoW7 =AhPf -----END PGP SIGNATURE----- --5vNYLRcllDrimb99--