Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3268283pxj; Tue, 1 Jun 2021 01:06:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyFHWButEvXA2e+h8HwIQ1LwHIYnydIV7reeHR+mkuCNR6pIlI1l8rh9+A91DWOKdj/qmBe X-Received: by 2002:a17:906:f84:: with SMTP id q4mr28892099ejj.442.1622534778793; Tue, 01 Jun 2021 01:06:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622534778; cv=none; d=google.com; s=arc-20160816; b=sYT7OUg5HPpXGoBwR7jtO/iWCiapJIKIv5oN4/wAv3udQ3CvZ7HBCqSBtfp5JeKowq J2pY+eff4arvV3cq7s9BnZXhglZLqrX61Qvod6013zNpZSjJBUXxgag3WNVG0NdhTDho 4utlRzSkUDlKuef6xILKVM0UuTNMaVRNaoW5oPD2nb55h5719V+RF/LOXOZ+JEHxt2ob isborJpk6Wr7yFV03q0pMyaHvGGkJlRWBFLjkGwBdYMe2rLMxn7r3CWM08+uweLuTBgz QBhRSkD0npSRGBRgdKbedTiKrZKxzCGu3A0oZ7xZrr0MRazVio5WFERGD5BV9sGeM/ba th3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=QCzVRV8L1fbtMtlNRd+CuhFKPjnvGS4FczJfnNNp23s=; b=fV6kD+T5roma0W/kI1KwkuxUy5eDJ6Sz3iCHsHRlfIZNPJltPcdwddSC9Tn0ta2Pww 8MrDA+1NWzqj//fE7gyhNXk4mJvRGhgoMt95G9K7lkPinoTV+bZu8M2UcemKDnlGDPYF njfOMWfREZ3cYb42O22LrkewqcZzfrqjPry2jSZkV6UG9RsowsZVLvHVSwhAcfSpTnmk +FxPZCBQpquQZPtA3o267+f60l1VqPLXHgnrX9TmHJiRF/Y3egYyP/J+4sAVfbD9xIj9 CeH/oYfvwjzBGINfJp6Dj1s5VG0fu/lrtS3jP+IHU56s4EJIn0i+zWIedi/BuGqfr90S dphA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c10si13117025edn.209.2021.06.01.01.05.56; Tue, 01 Jun 2021 01:06:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233294AbhFAIHa (ORCPT + 99 others); Tue, 1 Jun 2021 04:07:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233056AbhFAIH1 (ORCPT ); Tue, 1 Jun 2021 04:07:27 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D5ECC06174A; Tue, 1 Jun 2021 01:05:45 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1lnzPD-000V6C-GZ; Tue, 01 Jun 2021 10:05:43 +0200 From: Johannes Berg To: linux-wireless@vger.kernel.org, netdev@vger.kernel.org Cc: m.chetan.kumar@intel.com, loic.poulain@linaro.org, Johannes Berg Subject: [RFC 1/4] iosm: fix stats and RCU bugs in RX Date: Tue, 1 Jun 2021 10:05:35 +0200 Message-Id: <20210601100320.48d067d87f3e.I53608f5de5828db7066d29e5774bcf8a19e0f642@changeid> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210601080538.71036-1-johannes@sipsolutions.net> References: <20210601080538.71036-1-johannes@sipsolutions.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Johannes Berg Signed-off-by: Johannes Berg --- drivers/net/wwan/iosm/iosm_ipc_wwan.c | 25 +++++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/drivers/net/wwan/iosm/iosm_ipc_wwan.c b/drivers/net/wwan/iosm/iosm_ipc_wwan.c index 02c35bc86674..719c88d9b2e9 100644 --- a/drivers/net/wwan/iosm/iosm_ipc_wwan.c +++ b/drivers/net/wwan/iosm/iosm_ipc_wwan.c @@ -312,7 +312,8 @@ int ipc_wwan_receive(struct iosm_wwan *ipc_wwan, struct sk_buff *skb_arg, bool dss, int if_id) { struct sk_buff *skb = skb_arg; - struct net_device_stats stats; + struct net_device_stats *stats; + struct iosm_net_link *priv; int ret; if ((skb->data[0] & IOSM_IP_TYPE_MASK) == IOSM_IP_TYPE_IPV4) @@ -325,19 +326,27 @@ int ipc_wwan_receive(struct iosm_wwan *ipc_wwan, struct sk_buff *skb_arg, if (if_id < (IP_MUX_SESSION_START - 1) || if_id > (IP_MUX_SESSION_END - 1)) { - dev_kfree_skb(skb); - return -EINVAL; + ret = -EINVAL; + goto free; } rcu_read_lock(); - skb->dev = rcu_dereference(ipc_wwan->sub_netlist[if_id])->netdev; - stats = rcu_dereference(ipc_wwan->sub_netlist[if_id])->netdev->stats; - stats.rx_packets++; - stats.rx_bytes += skb->len; + priv = rcu_dereference(ipc_wwan->sub_netlist[if_id]); + if (!priv) { + ret = -EINVAL; + goto unlock; + } + skb->dev = priv->netdev; + stats = &priv->netdev->stats; + stats->rx_packets++; + stats->rx_bytes += skb->len; ret = netif_rx(skb); + skb = NULL; +unlock: rcu_read_unlock(); - +free: + dev_kfree_skb(skb); return ret; } -- 2.31.1