Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210608170449.28031-1-m.chetan.kumar@intel.com> <20210608170449.28031-17-m.chetan.kumar@intel.com>
In-Reply-To: <20210608170449.28031-17-m.chetan.kumar@intel.com>
From:   Sergey Ryazanov <ryazanov.s.a@gmail.com>
Date:   Sat, 12 Jun 2021 04:18:36 +0300
Message-ID: <CAHNKnsSgcf5PWvPhUJuXibamUR6oZt2xLLzNLwQP8OM1e0A1Bg@mail.gmail.com>
Subject: Re: [PATCH V4 16/16] net: iosm: infrastructure
To:     M Chetan Kumar <m.chetan.kumar@intel.com>
Cc:     netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
        Johannes Berg <johannes@sipsolutions.net>,
        krishna.c.sudi@intel.com, linuxwwan@intel.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hello Chetan,

On Tue, Jun 8, 2021 at 8:09 PM M Chetan Kumar <m.chetan.kumar@intel.com> wrote:

[skipped]

> +/dev/wwan0p3MBIM character device
> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> +The driver exposes an MBIM interface to the MBIM function by implementing
> +MBIM WWAN Port. The userspace end of the control channel pipe is a
> +/dev/wwan0p3MBIM character device. Application shall use this interface for
> +MBIM protocol communication.

A one nitpick. Since f458709ff40b ("net: wwan: core: make port names
more user-friendly") the first device MBIM control port will be
/dev/wwan0mbim0. If you plan to send a next version, please update the
port name in the documentation.

-- 
Sergey