Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2007984pxj; Sun, 13 Jun 2021 05:52:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzK7IiqJkJw+FxSHoMcYR+raKRrTQlQSgmUilQ3iarxyzaPTbpFsdRramvWjYW3ww+FPR7n X-Received: by 2002:a17:906:264c:: with SMTP id i12mr11275078ejc.101.1623588726831; Sun, 13 Jun 2021 05:52:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623588726; cv=none; d=google.com; s=arc-20160816; b=mIxJwFpmf6Z53PhorFAkCD6AW4//Jb1AGgwSrbbrajvSKOdqDMgms5BBo86PiT+a16 DuG4ChjuHDdSDe/OC2ohT5sDkSuvmKtqLHf+HeVnEz1rQ94XDkW4ccpFDN/9VHzLLOFy 0M1JFwXN99HLwYgYhv6lR+tg0Vwns73r8vB3vHaR/5Isoji9c+psgAMD/xrLsFY0NtaK Ja6xdj923GOY0DBQ9m8v1IAy/cbmLB8LC4TD1Nr5Q3jFh3xqOlw/9fLJNHHBz/ZowzSY 6S85TVHIJPk3dP8aeT4Qfa3UPJkuV3dfvpWjhg5IYTT2LrzSdjCqupzh7/I62lkEbQi5 nt9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:ironport-sdr:ironport-sdr; bh=BgCRK10IJuuFuxpfH2hJBbPGB7znW8eCl3PQgXEX8rg=; b=ejn3k6+aZDdLeSqyQC5ocJiFzGFcw8QZSm+pDCYDTJvFPCj65zN5BtqUEiIW+ZOknM QnAmQdo4i39S3AQIZOr5fhfjzzLmtjxBl62b0NQOf2Cnrgx49mCTOikZJ8/oI+HVeyQD n3Ll6hDz4/UGSL/mVxDrfM+8tga5zxNDuSqtM60+HP/CTOqx5eSaA7OgpHsJBZMygkjs UAt0FRNbkWdqni+BgY6NUbDe2aaWadYqRmtEoGVHzxSdHRMpxAxpbef79fMHxP4hnXLt rznnV6ycuKPIBhA+2opzlsum6ZzEJH3oK0kHFz7YlZDL4Xw3SK3tf3vbpRCmB8uOS3J4 P8iw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h3si9454213edf.193.2021.06.13.05.51.36; Sun, 13 Jun 2021 05:52:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231829AbhFMMwt (ORCPT + 99 others); Sun, 13 Jun 2021 08:52:49 -0400 Received: from mga01.intel.com ([192.55.52.88]:20206 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231815AbhFMMwr (ORCPT ); Sun, 13 Jun 2021 08:52:47 -0400 IronPort-SDR: sKGS6hQtx/vcIavbUE9lXAJb46IFEWaT758abg6GWp+bReDKUfA3SAR4dEAtE4E+ZUXy64kbGU JlLUKqmn5qyA== X-IronPort-AV: E=McAfee;i="6200,9189,10013"; a="227158457" X-IronPort-AV: E=Sophos;i="5.83,271,1616482800"; d="scan'208";a="227158457" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jun 2021 05:50:46 -0700 IronPort-SDR: Fr8a/o9oRRS5eqt5CoNXYDHNCq0DSDmUBRw7LpMrUpsQS3QkgUQ8aqb4HQPD8IH2ZRMgpacYeS gD8CSQA2hyHQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,271,1616482800"; d="scan'208";a="449612940" Received: from bgsxx0031.iind.intel.com ([10.106.222.40]) by orsmga008.jf.intel.com with ESMTP; 13 Jun 2021 05:50:44 -0700 From: M Chetan Kumar To: netdev@vger.kernel.org, linux-wireless@vger.kernel.org Cc: johannes@sipsolutions.net, krishna.c.sudi@intel.com, linuxwwan@intel.com Subject: [PATCH V5 02/16] net: iosm: irq handling Date: Sun, 13 Jun 2021 18:20:09 +0530 Message-Id: <20210613125023.18945-3-m.chetan.kumar@intel.com> X-Mailer: git-send-email 2.12.3 In-Reply-To: <20210613125023.18945-1-m.chetan.kumar@intel.com> References: <20210613125023.18945-1-m.chetan.kumar@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org 1) Request interrupt vector, frees allocated resource. 2) Registers IRQ handler. Signed-off-by: M Chetan Kumar --- v5: no change. v4: no change. v3: * Removed inline keyword in .c file. * Aligned ipc_ prefix for function name to be consistent across file. v2: Streamline multiple returns using goto. --- drivers/net/wwan/iosm/iosm_ipc_irq.c | 90 ++++++++++++++++++++++++++++ drivers/net/wwan/iosm/iosm_ipc_irq.h | 33 ++++++++++ 2 files changed, 123 insertions(+) create mode 100644 drivers/net/wwan/iosm/iosm_ipc_irq.c create mode 100644 drivers/net/wwan/iosm/iosm_ipc_irq.h diff --git a/drivers/net/wwan/iosm/iosm_ipc_irq.c b/drivers/net/wwan/iosm/iosm_ipc_irq.c new file mode 100644 index 000000000000..702f50a48151 --- /dev/null +++ b/drivers/net/wwan/iosm/iosm_ipc_irq.c @@ -0,0 +1,90 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright (C) 2020-21 Intel Corporation. + */ + +#include "iosm_ipc_pcie.h" +#include "iosm_ipc_protocol.h" + +static void ipc_write_dbell_reg(struct iosm_pcie *ipc_pcie, int irq_n, u32 data) +{ + void __iomem *write_reg; + + /* Select the first doorbell register, which is only currently needed + * by CP. + */ + write_reg = (void __iomem *)((u8 __iomem *)ipc_pcie->ipc_regs + + ipc_pcie->doorbell_write + + (irq_n * ipc_pcie->doorbell_reg_offset)); + + /* Fire the doorbell irq by writing data on the doorbell write pointer + * register. + */ + iowrite32(data, write_reg); +} + +void ipc_doorbell_fire(struct iosm_pcie *ipc_pcie, int irq_n, u32 data) +{ + ipc_write_dbell_reg(ipc_pcie, irq_n, data); +} + +/* Threaded Interrupt handler for MSI interrupts */ +static irqreturn_t ipc_msi_interrupt(int irq, void *dev_id) +{ + struct iosm_pcie *ipc_pcie = dev_id; + int instance = irq - ipc_pcie->pci->irq; + + /* Shift the MSI irq actions to the IPC tasklet. IRQ_NONE means the + * irq was not from the IPC device or could not be served. + */ + if (instance >= ipc_pcie->nvec) + return IRQ_NONE; + + if (!test_bit(0, &ipc_pcie->suspend)) + ipc_imem_irq_process(ipc_pcie->imem, instance); + + return IRQ_HANDLED; +} + +void ipc_release_irq(struct iosm_pcie *ipc_pcie) +{ + struct pci_dev *pdev = ipc_pcie->pci; + + if (pdev->msi_enabled) { + while (--ipc_pcie->nvec >= 0) + free_irq(pdev->irq + ipc_pcie->nvec, ipc_pcie); + } + pci_free_irq_vectors(pdev); +} + +int ipc_acquire_irq(struct iosm_pcie *ipc_pcie) +{ + struct pci_dev *pdev = ipc_pcie->pci; + int i, rc = -EINVAL; + + ipc_pcie->nvec = pci_alloc_irq_vectors(pdev, IPC_MSI_VECTORS, + IPC_MSI_VECTORS, PCI_IRQ_MSI); + + if (ipc_pcie->nvec < 0) { + rc = ipc_pcie->nvec; + goto error; + } + + if (!pdev->msi_enabled) + goto error; + + for (i = 0; i < ipc_pcie->nvec; ++i) { + rc = request_threaded_irq(pdev->irq + i, NULL, + ipc_msi_interrupt, IRQF_ONESHOT, + KBUILD_MODNAME, ipc_pcie); + if (rc) { + dev_err(ipc_pcie->dev, "unable to grab IRQ, rc=%d", rc); + ipc_pcie->nvec = i; + ipc_release_irq(ipc_pcie); + goto error; + } + } + +error: + return rc; +} diff --git a/drivers/net/wwan/iosm/iosm_ipc_irq.h b/drivers/net/wwan/iosm/iosm_ipc_irq.h new file mode 100644 index 000000000000..a8ed596cb6a5 --- /dev/null +++ b/drivers/net/wwan/iosm/iosm_ipc_irq.h @@ -0,0 +1,33 @@ +/* SPDX-License-Identifier: GPL-2.0-only + * + * Copyright (C) 2020-21 Intel Corporation. + */ + +#ifndef IOSM_IPC_IRQ_H +#define IOSM_IPC_IRQ_H + +struct iosm_pcie; + +/** + * ipc_doorbell_fire - fire doorbell to CP + * @ipc_pcie: Pointer to iosm_pcie + * @irq_n: Doorbell type + * @data: ipc state + */ +void ipc_doorbell_fire(struct iosm_pcie *ipc_pcie, int irq_n, u32 data); + +/** + * ipc_release_irq - Release the IRQ handler. + * @ipc_pcie: Pointer to iosm_pcie struct + */ +void ipc_release_irq(struct iosm_pcie *ipc_pcie); + +/** + * ipc_acquire_irq - acquire IRQ & register IRQ handler. + * @ipc_pcie: Pointer to iosm_pcie struct + * + * Return: 0 on success and failure value on error + */ +int ipc_acquire_irq(struct iosm_pcie *ipc_pcie); + +#endif -- 2.25.1