Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3537346pxj; Tue, 15 Jun 2021 03:11:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyjXm9Y6zBXExEf+iAdVEC/bQkQej6/6lYyTZax9XFSwgbNw3J+3PdOCT9yp/LxakGEp8Fp X-Received: by 2002:aa7:ca1a:: with SMTP id y26mr22063126eds.314.1623751877888; Tue, 15 Jun 2021 03:11:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623751877; cv=none; d=google.com; s=arc-20160816; b=Cjqg/4UbjSBo8UASqgcJeZUpOwnM6o/M3WpEGD/nbqrKy168WWiZk+F53E+DIJT8Z9 Hx/+7uDt5zs/+v5BaD1gd5ELqeVEifBVag2LutwS8crD16GI1I1WxqfWlgJ2I29+9RyU 9M8mw3zIZys25wDGH9XX8P3sCTMj9BiV4bv1Rki2QeSvAoPY2g5EsoqYnLpqd9iYYJ6L HbfYKSxxZXvKmybhXh47nGj/WTCT5G/BWjPuySJHdwvEL56PG6KENqFQS0lMn47nbpt4 Ad9y720OZCwjdk9zTWPoGm9438Bg0STl/ghvzfvwV99iF37J/AzlFYLrLx7I+2gOXFVL qDJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dmarc-filter:sender:dkim-signature; bh=Wnx0dnJAasSI19113sOftFNVrI60o7qtI8hrUanoFFQ=; b=rPrBeOLcW9J/J84ASrJhcWVFDGOJbH4Lcp6WpiyMe/b1zuL6miwZSzyLHCG9C8otGg lBHDZiT87byw8+y2ML+FlH93kRHcA8aiWVfbJwBfmhZ6a2KIZ5dwC+Pm2y5uBfeGha9M Grkmgfa+QCE6H07UQvfyUkTrkQfl9yQLJ8QeQjUHDiZuif2b1Qw96AgWUbUQjuB+Dgs0 MpD49Ka4FqW0xXwuVW6os76AMM72bmJq9Ams94CbEHE4GAazcRAjpMamnlfiV4XOuWze TSmeAhUhlh9EZ6K77vVdFEPNYO67x6dGlvnc576PiokB83TLh4mN5senwZpJUh8Pl6YG 1Xng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b="s8/BX8cY"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q24si13870082ejn.752.2021.06.15.03.10.55; Tue, 15 Jun 2021 03:11:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b="s8/BX8cY"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231463AbhFOKMm (ORCPT + 99 others); Tue, 15 Jun 2021 06:12:42 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:24475 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230519AbhFOKMl (ORCPT ); Tue, 15 Jun 2021 06:12:41 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1623751838; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=Wnx0dnJAasSI19113sOftFNVrI60o7qtI8hrUanoFFQ=; b=s8/BX8cYyGvjQrfzB3yeabm/8DfY8KbPIBbv8dwd2Ht5/dMHJesL639PjYp/Jt7jv9Tt/l5V UlX5qg4WeaXfqPozfHoDPH3r4xqHnbDRTG9hovu7lMxSHlor/RInpinZKT6w8dUOz32x+Bm0 uGeLGAXlIN/Ejr5irCijydjCfq8= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 60c87c918491191eb32b9948 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 15 Jun 2021 10:10:25 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 912B9C43144; Tue, 15 Jun 2021 10:10:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,BAYES_00, MISSING_DATE,MISSING_MID,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from tykki.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 076C6C4338A; Tue, 15 Jun 2021 10:10:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 076C6C4338A Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] ssb: Remove redundant assignment to err From: Kalle Valo In-Reply-To: <1619693230-108804-1-git-send-email-yang.lee@linux.alibaba.com> References: <1619693230-108804-1-git-send-email-yang.lee@linux.alibaba.com> To: Yang Li Cc: m@bues.ch, nathan@kernel.org, ndesaulniers@google.com, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Yang Li User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-Id: <20210615101025.912B9C43144@smtp.codeaurora.org> Date: Tue, 15 Jun 2021 10:10:25 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Yang Li wrote: > Variable 'err' is set to zero but this value is never read as it is > overwritten with a new value later on, hence it is a redundant > assignment and can be removed. > > Clean up the following clang-analyzer warning: > > drivers/ssb/main.c:1306:3: warning: Value stored to 'err' is never read > [clang-analyzer-deadcode.DeadStores] > drivers/ssb/main.c:1312:3: warning: Value stored to 'err' is never read > [clang-analyzer-deadcode.DeadStores] > > Reported-by: Abaci Robot > Signed-off-by: Yang Li > Acked-by: Michael Büsch Patch applied to wireless-drivers-next.git, thanks. 7557dfde1bd1 ssb: Remove redundant assignment to err -- https://patchwork.kernel.org/project/linux-wireless/patch/1619693230-108804-1-git-send-email-yang.lee@linux.alibaba.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches