Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3538384pxj; Tue, 15 Jun 2021 03:12:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxwqwkB8RHhFIwaMfUOznV9Gq9VcAc3d/MkxvbMFFTsVTCuzmMGVzMopKhTLVEqFwxuXqVu X-Received: by 2002:a50:fb8a:: with SMTP id e10mr23054856edq.330.1623751969355; Tue, 15 Jun 2021 03:12:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623751969; cv=none; d=google.com; s=arc-20160816; b=bSWofpzq7NdHrPx5U+oEXWBp3uwdjRvpMDW6XCI1YNGu8VMks5GLvZkUAHNgYi1t3e BrpCVdv+PpqiFD2RWXXqCADFQP7N9mklg9CwOSjS6hzfyql+n76Y+YSNzTcn/388RLx3 455KQttjRBvvnr0WjF+ZXIA1+XwMgrR46M+XgWFFNXB3IAXKsmDWQeRwp52c6Ep4lnmf eo4iZkP2udSmN9euaLidOQRbQe/Ud6hYdF8HyJT8AP8FDSXFtdurPeJ/rHBRhy9FwYkt +R2GK8R7u2gN9BCGqpF7oNfB/SwsNn/UBdghHutvqIETDSMrbuOkhfJvS4E7mbijpKuf b1Yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dmarc-filter:sender:dkim-signature; bh=HtF3PF2tjZafAWrKo+UP2bf/9Xr+8dpjl2fpn8A22zA=; b=jQ+jzK4BL2iHLWSgEn6AmZSVMDaJhJy2BTYJD5SrR4i2uwjm5g//EtBRI9ya97z8qj eoKWiWGNRW74WWYksEz+kP8JEfe5GUPM7BpRfN7hWryHTxw/Q6faPNEO9LfJ0Kj4TJ58 nuQ9Of0yEkJ7M4qx1EnMyF/mp0J38i2UlQ2cyy+8T2gOYbjETSDy74djbZelLt97mlbt wyUoYijS4eXf4biVX2haP3jeMQ8pPbZBC8UYQamnFDObGxhxQI9Vqet5Hvp6cxXnsQxC VQGdCsDE8+gyvCixXQRNYj5C1AlwSwd4uafhJtmYmzjmN1rGbPYF4ye/xXyUm8cUYjlz z58w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=X5kvuwaB; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id aq5si13070093ejc.19.2021.06.15.03.12.25; Tue, 15 Jun 2021 03:12:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=X5kvuwaB; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231345AbhFOKOU (ORCPT + 99 others); Tue, 15 Jun 2021 06:14:20 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:55499 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231504AbhFOKOR (ORCPT ); Tue, 15 Jun 2021 06:14:17 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1623751933; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=HtF3PF2tjZafAWrKo+UP2bf/9Xr+8dpjl2fpn8A22zA=; b=X5kvuwaBm2H53wRKH5iKZi+BjaUxKGHXsNF0AlshIYmtUXqs1YAdKN9Vn4W330ga/Rvj1HVu Vf9UbfznEVRZEHaelIeK1Sc/8alkZMK1w/qNg5D3+9hcecHV5DdSERjkCXbwDmzlkH9laca3 62jQwNiYVKfCEnhtOKh9sZv8D4g= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-east-1.postgun.com with SMTP id 60c87cfcf726fa4188d9a346 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 15 Jun 2021 10:12:12 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id A6D01C43460; Tue, 15 Jun 2021 10:12:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,BAYES_00, MISSING_DATE,MISSING_MID,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from tykki.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 1B479C433F1; Tue, 15 Jun 2021 10:12:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1B479C433F1 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2 1/1] ssb: use DEVICE_ATTR_ADMIN_RW() helper macro From: Kalle Valo In-Reply-To: <20210603082218.11718-2-thunder.leizhen@huawei.com> References: <20210603082218.11718-2-thunder.leizhen@huawei.com> To: Zhen Lei Cc: Michael Buesch , linux-wireless , Zhen Lei User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-Id: <20210615101211.A6D01C43460@smtp.codeaurora.org> Date: Tue, 15 Jun 2021 10:12:11 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Zhen Lei wrote: > Use DEVICE_ATTR_ADMIN_RW() helper macro instead of DEVICE_ATTR(), making > it simpler and easier to read. > > Because the read and write function names of the sysfs attribute have been > normalized, there is a natural association. > > Signed-off-by: Zhen Lei Patch applied to wireless-drivers-next.git, thanks. 573f1af86891 ssb: use DEVICE_ATTR_ADMIN_RW() helper macro -- https://patchwork.kernel.org/project/linux-wireless/patch/20210603082218.11718-2-thunder.leizhen@huawei.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches