Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3538509pxj; Tue, 15 Jun 2021 03:13:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw7XTtl/XaTwJMzkXKUL49NwuWJddbNtlAb3q8AU61MJALjsBVxt3IE1SBfgwSm9x7Y29TR X-Received: by 2002:a92:cd8d:: with SMTP id r13mr17432927ilb.93.1623751983001; Tue, 15 Jun 2021 03:13:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623751982; cv=none; d=google.com; s=arc-20160816; b=noZTeHY5AUWZFFGcAh+sKKzxyDBQ+jr+qLt8QDnTQk5+IdEg5O5c+vfEtbamaBTfox uQ8ix076KdLKjzL8NwPFun6QIyylckl7xsGutRKqTeqjDbANMCpBTGqknjodny1AS+wp 0wBQz0ZfwE8N+gC64q60bSVJRvvGABaY+dKRL3fA8fZixgezQ5v1hmoxpawn6voDiYeJ zks9SEGrq6u4eldQFzzGn5CS5V56FIAHvqXBLF30MFWTVhOWNmpZWTeysxZKVa2TRmr1 HkjXkBEE/c6JIm7HsQtwy6rGUdCCaceehbSKnZWUerOBHd41HMIXH8eQ9qwrslvzc/7P BbAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dmarc-filter:sender:dkim-signature; bh=dM+rT4E8kvhSQ3XqvTxEolQ8Qn2/02mGOb9Z5VpJ4/I=; b=x9VxGVAxnkyfwDuZWfmBasfVgDNs9s6RzE/iyrcZCqnnud5YLfDNrmUgmd0u0Qo0+u 6eT9ITs/mlKeQHjYFEm1wOLmPsU/YMbRZ6AIdt5624fFYXMNrz/mxCvf8yaUYtdaYz/3 NS4DimseOFIjs3vprYX3F/oHnIyehW5YXyK6Yk5WZ5WWKPqMk1RNDyweF+ebJvoXrImi gHnTyNUfREKlB/HeDyAnqee5jenBpalfxW9M+gD+cjqratws6gb9M8oOl0XJ8We7CpWO BidrgaeDlrnB1nQC9S9fL7Te989Pkj8wBP18l3lRLHXewibE6vwXV6NtlB1Ho1LaDCyp fPuA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=TH3kP3nJ; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i9si18547071ila.58.2021.06.15.03.12.42; Tue, 15 Jun 2021 03:13:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=TH3kP3nJ; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231362AbhFOKNm (ORCPT + 99 others); Tue, 15 Jun 2021 06:13:42 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:58968 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231290AbhFOKNl (ORCPT ); Tue, 15 Jun 2021 06:13:41 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1623751897; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=dM+rT4E8kvhSQ3XqvTxEolQ8Qn2/02mGOb9Z5VpJ4/I=; b=TH3kP3nJqjJKHzJerTBz4lrWzojmNTg9Qdti4xhEEdS+9qO5a/e0sa5HwNG1jyH1waz/de9m xdeWycan1xjkf5F6fHuBspBBmBYX7R22ZikFOd9QbFeWtRQNvLJAc93w3wVPYg2F8kudXMWZ iFPGhZhHnFb7aKNg4Od4dfbW3C8= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 60c87cc98491191eb32cef7c (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 15 Jun 2021 10:11:21 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id D987DC4338A; Tue, 15 Jun 2021 10:11:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,BAYES_00, MISSING_DATE,MISSING_MID,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from tykki.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id D8887C433D3; Tue, 15 Jun 2021 10:11:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D8887C433D3 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: ssb: sdio: Don't overwrite const buffer if block_write fails From: Kalle Valo In-Reply-To: <20210515210252.318be2ba@wiggum> References: <20210515210252.318be2ba@wiggum> To: Michael =?utf-8?b?QsO8c2No?= Cc: linux-wireless@vger.kernel.org, Albert Herranz User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-Id: <20210615101121.D987DC4338A@smtp.codeaurora.org> Date: Tue, 15 Jun 2021 10:11:21 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Michael Büsch wrote: > It doesn't make sense to clobber the const driver-side buffer, if a > write-to-device attempt failed. All other SSB variants (PCI, PCMCIA and SoC) > also don't corrupt the buffer on any failure in block_write. > Therefore, remove this memset from the SDIO variant. > > Signed-off-by: Michael Büsch > Cc: stable@vger.kernel.org Patch applied to wireless-drivers-next.git, thanks. 47ec636f7a25 ssb: sdio: Don't overwrite const buffer if block_write fails -- https://patchwork.kernel.org/project/linux-wireless/patch/20210515210252.318be2ba@wiggum/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches