Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3554556pxj; Tue, 15 Jun 2021 03:37:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx6JYEPGnraHA1PZsWpg1+R5xa+34Vy9VKgeaN+djTAq9rJpk0YVucj7eskfkFwgpxwmfST X-Received: by 2002:a02:956a:: with SMTP id y97mr4661074jah.58.1623753452672; Tue, 15 Jun 2021 03:37:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623753452; cv=none; d=google.com; s=arc-20160816; b=s3ytSb4JwnQI5tbQnkEnVLacp56CUXKZUFBgzx7ofI3fg57sZN0Am6EjKrgatgYHD4 AEb9VWiXdL0Y0Hoo/bvlZ9Fgpm5zvOcRFRV1Mep1CEqrwbqlp64ghZ/sujQttX1xX+ea D+b+lbMd9JJ+G77ElnVYFCZBKxeAX4U0ML8ZXDl99hkFOmUHlaMu/bB/rQX/1mWZ8imu 3fL6aRAg6G5Lixv5EXM1nyc7BMqUfRR11ALzLAe1a6fjJfYuuUoN6XipJ3jxaoZehLs9 50ny3B65gapnOoKMCd7X7tcmudJu+iOUCajhM/iELs31rjhfoeyymJ5nd6nKYrkVZ34q IyYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dmarc-filter:sender:dkim-signature; bh=ksckzWO9VmurR/0PhO+oOToCabvoksQAxJ52rnjPBhA=; b=a+iQaNd83n6+hhqXWmxpJ5g4gw9mRVvKg9+Mr1cavhrHakOOGy4u++e9gPgcjXTgik KwH5WB8tSRv36TwdbH4ZgJf6mfeUz6ZPnFiGvjgvOAcVLm81OwD4cWytAsqVAi6jqDX6 d3t/rIikAUsQIsI94870/o/8jvJZRfO4QGVHGVJZPs5GjW/oLl2IRHyWyOjYWJ6fWeNC MvZuF73m+0I8PbL1Z7lU1WJpK5F3zWUx2LHZC0kzNUHTHX71v5lAffr8hLr2XY9xr9qZ FnrZYzb/LN/uaVF8yan7Z8lHMSEgQlriRMnJ92wYRDeGakZs8J7MbaP/oqKt0L7h72Qr fvHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=rJdQpFEh; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i7si19026816ilk.55.2021.06.15.03.37.19; Tue, 15 Jun 2021 03:37:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=rJdQpFEh; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231727AbhFOKjG (ORCPT + 99 others); Tue, 15 Jun 2021 06:39:06 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:18652 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231664AbhFOKjE (ORCPT ); Tue, 15 Jun 2021 06:39:04 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1623753420; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=ksckzWO9VmurR/0PhO+oOToCabvoksQAxJ52rnjPBhA=; b=rJdQpFEhB+LIPXF0zcazqGC7/VFnV8iyBKEgFCEMzT6Dk+ZOVlMw4bD7M6f2D0X2O7rDrpp1 9DVD4tRlWRgCcIof9IxPSb8ce7je8BIkt800gI3rTBOPp8ALvHbCqwclZukcL2ZukLEVlBCA iX9nrWMzV1xqIGwIhmMDBPoqUiY= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-east-1.postgun.com with SMTP id 60c882cae27c0cc77f2540ce (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 15 Jun 2021 10:36:58 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 174A9C43460; Tue, 15 Jun 2021 10:36:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,BAYES_00, MISSING_DATE,MISSING_MID,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from tykki.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 31F5DC433D3; Tue, 15 Jun 2021 10:36:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 31F5DC433D3 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [1/2] brcmfmac: fix setting of station info chains bitmask From: Kalle Valo In-Reply-To: <20210506132010.3964484-1-alsi@bang-olufsen.dk> References: <20210506132010.3964484-1-alsi@bang-olufsen.dk> To: =?utf-8?q?Alvin_=C5=A0ipraga?= Cc: Arend van Spriel , Franky Lin , Hante Meuleman , Chi-hsien Lin , Wright Feng , Chung-hsien Hsu , "linux-wireless@vger.kernel.org" , "brcm80211-dev-list.pdl@broadcom.com" , "SHA-cyfmac-dev-list@infineon.com" , =?utf-8?q?Alvin_=C5=A0ipraga?= User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-Id: <20210615103658.174A9C43460@smtp.codeaurora.org> Date: Tue, 15 Jun 2021 10:36:58 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Alvin Šipraga wrote: > The sinfo->chains field is a bitmask for filled values in chain_signal > and chain_signal_avg, not a count. Treat it as such so that the driver > can properly report per-chain RSSI information. > > Before (MIMO mode): > > $ iw dev wlan0 station dump > ... > signal: -51 [-51] dBm > > After (MIMO mode): > > $ iw dev wlan0 station dump > ... > signal: -53 [-53, -54] dBm > > Fixes: cae355dc90db ("brcmfmac: Add RSSI information to get_station.") > Signed-off-by: Alvin Šipraga 2 patches applied to wireless-drivers-next.git, thanks. feb456437621 brcmfmac: fix setting of station info chains bitmask 9a1590934d9a brcmfmac: correctly report average RSSI in station info -- https://patchwork.kernel.org/project/linux-wireless/patch/20210506132010.3964484-1-alsi@bang-olufsen.dk/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches